Backend Abstraction #67

lights0123 · 2021-03-27T02:22:48Z

Fixes #66. I'm leaving for a week in 2 days, but I just spent an hour or two working on this today, and I'll probably do a little more tomorrow. Feel free to build on this or just do something else completely.

This introduces a new trait, GenericNode. Right now, it only has one implementation, which is a real DOM node. I'm writing this in a way so that users will have to make their components generic, but will hopefully never have to specify what that generic type is because it'll be inferred from calling render().

Right now, I have the following questions I'll need to answer to go further:

Handling next_sibling and parent_node functions. When those just call JS functions, it's no problem because it has a full GC that can handle cyclic references. Although that's possible in Rust with some work, it would be more efficient if we could remove calls to those functions. I could also make those return an error server-side (they're only used for modifying the state), but it would make modifying the data impossible server-side—meaning you can't have some async computation render stuff later, or if you did, it'd have to be implemented differently.
NodeRef: How to do this in a user-friendly way: do we force the user to downcast to a concrete type? It would be nice to not hardcode it being a web_sys::Node, for use cases like React Native. However, there is probably no need for it to work on the server.

lights0123 · 2021-03-27T03:12:47Z

The basic Hello World demo compiles and works now.

Handling next_sibling and parent_node functions. When those just call JS functions, it's no problem because it has a full GC that can handle cyclic references. Although that's possible in Rust with some work, it would be more efficient if we could remove calls to those functions. I could also make those return an error server-side (they're only used for modifying the state), but it would make modifying the data impossible server-side—meaning you can't have some async computation render stuff later, or if you did, it'd have to be implemented differently.

I decided just to implement them for now. I'll probably make them error out on the server-side.

lights0123 · 2021-03-27T03:32:33Z

Hello World, Counter, Components, and the docs all work now. Todomvc doesn't, but that's only because it uses NodeRef. Tomorrow, I'll figure out what to do about that.

lights0123 · 2021-03-27T03:41:29Z

Although, before I do that, does this look good? The alternative way would be with feature flags. That may make NodeRef usage cleaner, but would be less flexible—if, for whatever reason, you'd like the client to be able to render both to the DOM and a string, you'd be prevented from doing so.

Actually, I think I came up with a solution: make NodeRef's get and other functions have a generic parameter which is DOMNode by default. The user can override it if desired for use with an alternate renderer.

lukechu10

Looks good. I think it would make more sense with feature flags because everything that is wasm-bindgen or web-sys would need to be put behind a conditional compilation flag anyways. Otherwise it won't compile on non wasm32 targets.
It would also be nice if we didn't have to make everything generic over G as that is a bit verbose.

The way you implemented this wasn't exactly the way I thought of doing it but that's OK. I was thinking more along the lines of GenericNode having a .to_node() method which would generate DomNodes from the GenericNode. What do you think?

examples/counter/src/main.rs

maple-core/src/internal.rs

lukechu10

Sorry I missed some of the new changes in my previous review

maple-core/src/generic_node/vdom.rs

lights0123 · 2021-03-27T20:42:00Z

everything that is wasm-bindgen or web-sys would need to be put behind a conditional compilation flag anyways. Otherwise it won't compile on non wasm32 targets.

That's not true—it just panics at runtime.

lukechu10 · 2021-03-28T04:58:27Z

That's not true—it just panics at runtime.

Yup you're right. My bad. Although I still don't like the generic type params on all the components. Maybe something could be done using dynamic dispatch?

Edit Forget when I said about dynamic dispatch. It doesn't make any sense. I just had an idea. How about making G have a default type of DomNode when a web feature is enabled or SsrNode when a ssr feature is enabled. When both features are enabled, we could either default it to DomNode or not provide a default. What do you think?

lukechu10 · 2021-03-28T05:03:17Z

Just looked at the ssr example you added and it really is quite impressive! Thanks a lot for all the work so far.

lukechu10 · 2021-03-28T05:44:39Z

About feature flags, it might be a good idea to add a ssr feature anyways to prevent penalizing users who don't use SSR with worse compile times.

This is not used for usual client-side operation: this is solely a replacement for the DOM when it's unavailable like on a server.

commit 9e4aa92 Author: Luke Chu <37006668+lukechu10@users.noreply.github.com> Date: Tue Mar 30 15:38:01 2021 -0700 Separate ssr and dom features commit 898c27b Author: Luke Chu <37006668+lukechu10@users.noreply.github.com> Date: Tue Mar 30 10:24:29 2021 -0700 Fix intra doc links commit 6417d75 Author: Luke Chu <37006668+lukechu10@users.noreply.github.com> Date: Tue Mar 30 09:56:35 2021 -0700 Move DomNode into submodule commit 971c776 Author: Luke Chu <37006668+lukechu10@users.noreply.github.com> Date: Tue Mar 30 09:37:57 2021 -0700 Rename vdom::Node to ssr_node::SsrNode commit 1f62d08 Author: Luke Chu <37006668+lukechu10@users.noreply.github.com> Date: Mon Mar 29 21:34:42 2021 -0700 Set default type for G depending on feature commit cf2b593 Author: Luke Chu <37006668+lukechu10@users.noreply.github.com> Date: Mon Mar 29 21:19:33 2021 -0700 Fix clippy issues commit 74b3975 Author: Luke Chu <37006668+lukechu10@users.noreply.github.com> Date: Mon Mar 29 16:00:19 2021 -0700 Add dom and ssr features

commit ace788c Author: Luke Chu <37006668+lukechu10@users.noreply.github.com> Date: Tue Mar 30 20:41:48 2021 -0700 Remove internal module commit c454e85 Author: Luke Chu <37006668+lukechu10@users.noreply.github.com> Date: Tue Mar 30 16:03:28 2021 -0700 Remove internal::attr commit b0ddb88 Author: Luke Chu <37006668+lukechu10@users.noreply.github.com> Date: Tue Mar 30 15:50:08 2021 -0700 Remove internal::element

maple-core/src/flow.rs

Co-authored-by: Ben Schattinger <developer@lights0123.com>

…aple into pr/67

lukechu10 · 2021-04-01T19:50:31Z

I'll fix the integration tests and I'll probably merge this. Thanks for all the work @lights0123!

lights0123 mentioned this pull request Mar 27, 2021

Support for static rendering #47

Closed

3 tasks

lukechu10 reviewed Mar 27, 2021

View reviewed changes

examples/counter/src/main.rs Outdated Show resolved Hide resolved

maple-core/src/internal.rs Outdated Show resolved Hide resolved

lukechu10 reviewed Mar 27, 2021

View reviewed changes

maple-core/src/generic_node/vdom.rs Outdated Show resolved Hide resolved

lukechu10 added C-enhancement Category: new feature or improvement to existing feature A-SSR Area: Server Side Rendering (SSR) and Static Site Generation (SSG) labels Mar 27, 2021

lukechu10 added this to the 0.5 milestone Mar 28, 2021

lukechu10 marked this pull request as ready for review March 31, 2021 04:43

lukechu10 mentioned this pull request Mar 31, 2021

#[component(...)] attribute macro #72

Closed

3 tasks

lights0123 and others added 15 commits April 1, 2021 11:39

Initial refactoring

0555db3

Make it work

301e668

Fix counter

b33cd48

Fix components example

e9684ee

Fix docs

a27946d

Start working on todomvc

7cd0757

Refactor out document function

f579e8a

Fix NodeRef

6f8b8c5

Fix tests

4339f69

Start working on VDOM

3038523

This is not used for usual client-side operation: this is solely a replacement for the DOM when it's unavailable like on a server.

Undo debugging changes

1f35d96

Add SSR demo

fb40b92

Trigger test on PR

5f3f674

Always run test.yml steps regardless of previous

13193b8

Make tests pass in CI

94e65e7

lukechu10 added 7 commits April 1, 2021 11:50

Fix text node codegen

ae35440

Remove type param from NodeRef::get

7145f66

Re-add type param to NodeRef::get

9544c71

Update wasm-bindgen-cli to 0.2.73 in netlify-build

905b624

Make web-sys and wasm-bindgen optional

858e08a

lukechu10 force-pushed the backend-abstraction branch from 1770083 to 858e08a Compare April 1, 2021 18:54

lukechu10 mentioned this pull request Apr 1, 2021

Hydrate DOM on client side #81

Closed

3 tasks

Fix compile errors

cc3a280

lights0123 commented Apr 1, 2021

View reviewed changes

maple-core/src/flow.rs Outdated Show resolved Hide resolved

maple-core/src/flow.rs Show resolved Hide resolved

lukechu10 and others added 3 commits April 1, 2021 12:44

Update maple-core/src/flow.rs

8365c0e

Co-authored-by: Ben Schattinger <developer@lights0123.com>

Make suggested changes

de4c7dc

Co-authored-by: Ben Schattinger <developer@lights0123.com>

Merge branch 'backend-abstraction' of https://github.com/lights0123/m…

ce29ce1

…aple into pr/67

lukechu10 added 5 commits April 1, 2021 12:53

Fix integration tests

a8f8c64

Create root in render_to_string

9e342e6

Add some docs for GenericNode

90d85c1

Add some more docs

84f2b45

cargo fmt

20ffa6c

lukechu10 enabled auto-merge (squash) April 1, 2021 20:36

lukechu10 merged commit 22909d5 into sycamore-rs:master Apr 1, 2021

lukechu10 mentioned this pull request Apr 3, 2024

View Backend v2! #669

Closed

8 tasks

lukechu10 mentioned this pull request Sep 4, 2024

View Backend v2! (Attempt 2) #679

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backend Abstraction #67

Backend Abstraction #67

lights0123 commented Mar 27, 2021

lights0123 commented Mar 27, 2021

lights0123 commented Mar 27, 2021

lights0123 commented Mar 27, 2021 •

edited

Loading

lukechu10 left a comment

lukechu10 left a comment

lights0123 commented Mar 27, 2021

lukechu10 commented Mar 28, 2021 •

edited

Loading

lukechu10 commented Mar 28, 2021

lukechu10 commented Mar 28, 2021

lukechu10 commented Apr 1, 2021

Backend Abstraction #67

Backend Abstraction #67

Conversation

lights0123 commented Mar 27, 2021

lights0123 commented Mar 27, 2021

lights0123 commented Mar 27, 2021

lights0123 commented Mar 27, 2021 • edited Loading

lukechu10 left a comment

Choose a reason for hiding this comment

lukechu10 left a comment

Choose a reason for hiding this comment

lights0123 commented Mar 27, 2021

lukechu10 commented Mar 28, 2021 • edited Loading

lukechu10 commented Mar 28, 2021

lukechu10 commented Mar 28, 2021

lukechu10 commented Apr 1, 2021

lights0123 commented Mar 27, 2021 •

edited

Loading

lukechu10 commented Mar 28, 2021 •

edited

Loading