Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SsrNode automatically create reactive nodes by default #737

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

lukechu10
Copy link
Member

Previous behavior: dynamic nodes created on the server were not actually dynamic, i.e. the values would not update even when signals are updated.

New behavior: dynamic nodes are always dynamic. This solves a bunch of inconsistencies and makes it easier to use resources which update the value dynamically.

@lukechu10 lukechu10 added the A-SSR Area: Server Side Rendering (SSR) and Static Site Generation (SSG) label Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 65.90909% with 15 lines in your changes missing coverage. Please review.

Project coverage is 72.10%. Comparing base (9f06fd5) to head (9f9869f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/sycamore-web/src/node/ssr_node.rs 60.52% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #737      +/-   ##
==========================================
+ Coverage   71.84%   72.10%   +0.26%     
==========================================
  Files          44       44              
  Lines        6282     6334      +52     
==========================================
+ Hits         4513     4567      +54     
+ Misses       1769     1767       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukechu10 lukechu10 force-pushed the ssr-nodes-reactive-by-default branch from 7f83bec to 9f9869f Compare October 23, 2024 20:24
@lukechu10 lukechu10 added performance Performance related and removed performance Performance related labels Oct 23, 2024
@lukechu10 lukechu10 merged commit b15fd1a into sycamore-rs:main Oct 23, 2024
10 of 12 checks passed
@lukechu10 lukechu10 deleted the ssr-nodes-reactive-by-default branch November 5, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-SSR Area: Server Side Rendering (SSR) and Static Site Generation (SSG)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant