Skip to content

Commit

Permalink
prov/verbs: Remove the word "maximum" from the env variable labels
Browse files Browse the repository at this point in the history
These environment variables define the default values when no hints
are provided. Remove the word "maximum" to avoid confusion over
whether these are a default value or a maximum value.

Signed-off-by: Sylvain Didelot <sdidelot@ddn.com>
  • Loading branch information
sydidelot committed Apr 4, 2024
1 parent 39b5740 commit e6f34f8
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
10 changes: 5 additions & 5 deletions man/fi_verbs.7.md
Original file line number Diff line number Diff line change
Expand Up @@ -163,21 +163,21 @@ The verbs provider checks for the following environment variables.
### Common variables:

*FI_VERBS_TX_SIZE*
: Default maximum tx context size (default: 384)
: Default tx context size (default: 384)

*FI_VERBS_RX_SIZE*
: Default maximum rx context size (default: 384)
: Default rx context size (default: 384)

*FI_VERBS_TX_IOV_LIMIT*
: Default maximum tx iov_limit (default: 4). Note: RDM (internal -
: Default tx iov_limit (default: 4). Note: RDM (internal -
deprecated) EP type supports only 1

*FI_VERBS_RX_IOV_LIMIT*
: Default maximum rx iov_limit (default: 4). Note: RDM (internal -
: Default rx iov_limit (default: 4). Note: RDM (internal -
deprecated) EP type supports only 1

*FI_VERBS_INLINE_SIZE*
: Default maximum inline size. Actual inject size returned in fi_info
: Default inline size. Actual inject size returned in fi_info
may be greater (default: 64)

*FI_VERBS_MIN_RNR_TIMER*
Expand Down
10 changes: 5 additions & 5 deletions prov/verbs/src/verbs_init.c
Original file line number Diff line number Diff line change
Expand Up @@ -615,31 +615,31 @@ static int vrb_get_param_str(const char *param_name,
int vrb_read_params(void)
{
/* Common parameters */
if (vrb_get_param_int("tx_size", "Default maximum tx context size",
if (vrb_get_param_int("tx_size", "Default tx context size",
&vrb_gl_data.def_tx_size) ||
(vrb_gl_data.def_tx_size < 0)) {
VRB_WARN(FI_LOG_CORE, "Invalid value of tx_size\n");
return -FI_EINVAL;
}
if (vrb_get_param_int("rx_size", "Default maximum rx context size",
if (vrb_get_param_int("rx_size", "Default rx context size",
&vrb_gl_data.def_rx_size) ||
(vrb_gl_data.def_rx_size < 0)) {
VRB_WARN(FI_LOG_CORE, "Invalid value of rx_size\n");
return -FI_EINVAL;
}
if (vrb_get_param_int("tx_iov_limit", "Default maximum tx iov_limit",
if (vrb_get_param_int("tx_iov_limit", "Default tx iov_limit",
&vrb_gl_data.def_tx_iov_limit) ||
(vrb_gl_data.def_tx_iov_limit < 0)) {
VRB_WARN(FI_LOG_CORE, "Invalid value of tx_iov_limit\n");
return -FI_EINVAL;
}
if (vrb_get_param_int("rx_iov_limit", "Default maximum rx iov_limit",
if (vrb_get_param_int("rx_iov_limit", "Default rx iov_limit",
&vrb_gl_data.def_rx_iov_limit) ||
(vrb_gl_data.def_rx_iov_limit < 0)) {
VRB_WARN(FI_LOG_CORE, "Invalid value of rx_iov_limit\n");
return -FI_EINVAL;
}
if (vrb_get_param_int("inline_size", "Default maximum inline size. "
if (vrb_get_param_int("inline_size", "Default inline size. "
"Actual inject size returned in fi_info may be "
"greater", &vrb_gl_data.def_inline_size) ||
(vrb_gl_data.def_inline_size < 0)) {
Expand Down

0 comments on commit e6f34f8

Please sign in to comment.