Rework inline formatting #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit simplifies the convoluted method in which inline formatting was handled. By splitting the overlapping inline formatting intervals into discrete slices that signifies how to style that slice, the logic for inline formatting can be simplified to a single loop instead of the recursive series of checks and dozens of while loops. This improves performance, code clarity, and fixes some long-standing bugs in the renderer. The caveat however is that the resulting HTML now has the chance to be much larger than before. This should be addressed as soon as possible.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4
This PR simplifies the convoluted method in which inline formatting was handled.
By splitting the overlapping inline formatting intervals into discrete slices that signifies how to style that slice, the logic for inline formatting can be simplified to a single loop instead of the recursive series of checks and dozens of while loops.
This improves performance, code clarity, and fixes some long-standing bugs in the renderer.
The caveat however is that the resulting HTML now has the chance to be much larger than before. This should be addressed as soon as possible.
Also fixes #2 albeit unintentionally