Use middleware to validate post slugs #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splits blog and blog post routes into two files and intergrated via a blueprint group
This commit removes the slug check logic from the former route handlers `_blog_post` and `_blog_post_no_slug`. Replacing this, is a middleware that handles the slug check logic instead. By using a middleware, we can apply this logic uniformly to all additional blog post routes. For example for a post note viewer ensuring that the endpoints to view post notes always has the correct slug if applicable, and to remove the given slug if unnecessary. As the logic that separated the slug and slugless post routes have been transformed to a single middleware, these two routes have been merged to use the same handler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the slug check logic from the former route handlers
_blog_postand_blog_post_no_slug. Replacing this, is a middlewarethat handles the slug check logic instead.
By using a middleware, we can apply this logic uniformly to all
additional blog post routes. For example for a post note viewer
ensuring that the endpoints to view post notes always has the correct
slug if applicable, and to remove the given slug if unnecessary.
As the logic that separated the slug and slugless post routes have
been transformed to a single middleware, these two routes have been
merged to use the same handler.