CI: Generate locale data during testing #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated locale data is not committed until a PR is merged. This means that when newly added languages are enabled the test instance ran by the CI attempts to fetch the data from an unavailable language causing an error. This PR generates the locale data prior to running the test instance. This does mean that the locale data generation script is ran twice once in the CI and once in the dedicated workflow but the script is simple enough that this duplication is irrelevant and attempts to fix it will complicate the workflows significantly
syeopite
force-pushed
the
generate-locale-data-in-test-ci
branch
from
2f1490d to
03a355d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated locale data is not committed until a PR is merged. This means that when newly added languages are enabled the test instance ran by the CI attempts to fetch the data from an unavailable language causing an error.
This PR generates the locale data prior to running the test instance. This does mean that the locale data generation script is ran twice once in the CI and once in the dedicated workflow but the script is simple enough that this duplication is irrelevant and attempts to fix it will complicate the workflows significantly