Reduce build dependencies in Dockerfile #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syeopite
reviewed
Jul 20, 2024
orjson has binary wheels for musl on amd64 and arm64 and pip doesn't need to be installed at runtime site-packages uses the most storage, so a multi-stage build doesn't help reduce it further
|
Sorry about that! |
| addgroup -g 1000 -S priviblur && \ | ||
| adduser -u 1000 -S priviblur -G priviblur && \ | ||
| pip3 install --break-system-packages -r requirements.txt && \ | ||
| apk add --no-cache py3-pip && \ |
There was a problem hiding this comment.
Why move this here instead of the first line?
There was a problem hiding this comment.
I thought it'd be slightly more clear to only declare the long-lived, runtime dependencies there.
There was a problem hiding this comment.
It looks like a mistake honestly :')
Also, you should have added a comment to say that it's only a build dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
orjsonis already installed as a musl binary (on amd64 and arm64).site-packagesuses the most storage, so a multi-stage build (like copying a venv) doesn't help reduce it further. (Although it would help if you do want to build from source packages)Fixes #58