Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
While conducting tests with the exporter, I observed something unusual in my packet capture: it appears that the ICMP check doesn't respect the count and always sends three packets:
In reality, it sends one ICMP packet per interval and initiates a new task at each interval until we reach
const MaxConcurrentJobs = 3
, as evident from theseq
being incremented properly to 19 (count was set to 20).This pull request addresses that issue, I believe. I also noticed that ICMP and TCP checks differed from the others, and attempted to standardize them/remove what seems to not really be used for interval management. However, this is my first time working with Go, so I'm not entirely sure. I may have missed something or made a mistake.
Thank you.