suggested changes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because it denotes a String value
This one is debatable. I mostly did it for my convenience, but I think PR tc39#2877 also preferred some similar expansions.
Because the result of IntegerIndexedObjectLength is `a non-negative integer of ~out-of-bounds~`, you need to deal with the `~out-of-bounds~` possibility before doing any arithmetic on it. Here, I've simply asserted that the result isn't `~out-of-bounds~`, but I don't know that that's true. You might have to do something different (e.g., throw).
RawBytesToNumeric returns a Number or a BigInt (in this case a BigInt), so convert that to a mathematical value for comparisons/arithmetic with a math value.
`_iieoRecord_` is `an Integer-Indexed Object With Buffer Witness Record`, which doesn't have `[[ViewedArrayBuffer]]` field.
`_O_` is a TypedArray, but IsFixedLengthArrayBuffer requires a [Shared]ArrayBuffer.
Its algorithm has a couple '?', so add 'throw completion' to its return type.
... based on the available evidence.
... because `_newLength_` could be any ES language value, but `_O_.[[ArrayBufferByteLength]]` requires a non-neg integer.
|
This all looks great, thanks for the many fixes! |
|
So all the |
I skimmed them and looked like it? They were all right after a ValidateTypedArray without any intervening user code, and ValidateTypedArray would've thrown for out-of-bounds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commit messages