Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: percentage fee strategy docs #206

Merged
merged 10 commits into from
Aug 31, 2023
Merged

chore: percentage fee strategy docs #206

merged 10 commits into from
Aug 31, 2023

Conversation

MakMuftic
Copy link
Contributor

Description

Related Issue Or Context

Closes: #181

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Go Test coverage is 65.7 %\ ✨ ✨ ✨

mpetrun5
mpetrun5 approved these changes Aug 7, 2023
View reviewed changes
docs/general/Fees.md Outdated Show resolved Hide resolved
@MakMuftic @mpetrun5
Update docs/general/Fees.md
0e6a5d6 
Co-authored-by: Matija Petrunić <matija.petrunic@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Go Test coverage is 65.7 %\ ✨ ✨ ✨

freddyli7
freddyli7 reviewed Aug 8, 2023
View reviewed changes
docs/general/Fees.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Go Test coverage is 65.7 %\ ✨ ✨ ✨

@github-actions
Copy link
Contributor

Go Test coverage is 65.7 %\ ✨ ✨ ✨

@MakMuftic MakMuftic merged commit 800cddf into main Aug 31, 2023
8 checks passed
@MakMuftic MakMuftic deleted the mmuftic/percentage-fee-docs branch August 31, 2023 11:03
@MakMuftic MakMuftic mentioned this pull request Aug 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmlinaric nmlinaric nmlinaric approved these changes

@mpetrun5 mpetrun5 mpetrun5 approved these changes

@P1sar P1sar Awaiting requested review from P1sar

@tcar121293 tcar121293 Awaiting requested review from tcar121293 tcar121293 is a code owner

@freddyli7 freddyli7 Awaiting requested review from freddyli7 freddyli7 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MakMuftic @freddyli7 @mpetrun5 @nmlinaric