feat: Upgrade to polkadot v0.9.37 #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tolak
commented
Feb 15, 2023
tolak
commented
freddyli7
approved these changes
Feb 15, 2023
| @@ -243,6 +243,7 @@ pub mod pallet { | |||
| { | |||
| /// Pause bridge, this would lead to bridge transfer failure before it being unpaused. | |||
| #[pallet::weight(195_000_000)] | |||
| #[pallet::call_index(0)] | |||
There was a problem hiding this comment.
I see now we have this call_index annotation in v0.9.37, is it a mandatory annotation for each extrinsic now from this version? I remember that when we worked on the access grant feature, we used to define a number for each extrinsic, then we decided to use a more readable and maintainable name, is this annotation related to that number?
There was a problem hiding this comment.
Yes, it is used to identify the extrinsic. We were planning to use the index but we thought the index may change. I have short discuss with parity team when they implement this function, suggested to add name too but they don't think runtime should care about the name, see here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.