Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*cider-repl-history* buffer (clojure layer) major mode key bindings shadowed #11159

Closed
paulrd opened this issue Aug 10, 2018 · 3 comments
Closed
Labels
Fixed in develop stale marked as a stale issue/pr (usually by a bot)

Comments

@paulrd
Copy link

paulrd commented Aug 10, 2018

Description :octocat:

Most of the keys for this major mode have been shadowed by evil mode.

Reproduction guide 🪲

  • Start Emacs
  • Open clojure code buffer.
  • Jack into a clojure repl (, ')
  • in that repl buffer, go to cider-repl-history via C-c M-p
  • hit q or Q to quit buffer

Observed behaviour: 👀 💔
Shadowed keys prevent the buffer from quitting

Expected behaviour: ❤️ 😄
Buffer should exit

System Info 💻

  • OS: gnu/linux
  • Emacs: 25.2.2
  • Spacemacs: 0.300.0
  • Spacemacs branch: develop (rev. 9af8e15)
  • Graphic display: t
  • Distribution: spacemacs
  • Editing style: vim
  • Completion: helm
  • Layers:
(javascript rust markdown helm clojure finance prodigy html java sql auto-completion emacs-lisp git treemacs
            (org :variables org-enable-hugo-support t)
            (shell :variables shell-default-height 30 shell-default-position 'bottom)
            spell-checking)
  • System configuration features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11

Backtrace 🐾

kommen added a commit to kommen/spacemacs that referenced this issue Oct 12, 2018
@kommen
Copy link
Contributor

kommen commented Oct 29, 2018

This issue is fixed in the develop branch.

See #11431

@d12frosted
Copy link
Contributor

@kommen thank you for reminder 😸

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

@github-actions github-actions bot added the stale marked as a stale issue/pr (usually by a bot) label Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in develop stale marked as a stale issue/pr (usually by a bot)
Projects
None yet
Development

No branches or pull requests

3 participants