Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a layer equivalent to pretty-fonts #11639

Closed
mdedetrich opened this issue Nov 25, 2018 · 18 comments
Closed

Provide a layer equivalent to pretty-fonts #11639

mdedetrich opened this issue Nov 25, 2018 · 18 comments
Labels
- Mailling list - Fonts New Layer stale marked as a stale issue/pr (usually by a bot)

Comments

@mdedetrich
Copy link

As can be seen by https://github.com/tonsky/FiraCode/wiki/Emacs-instructions providing font-ligatures to emacs is far more complicated than what it should be.

I think it makes sense to provide a layer analogous to https://github.com/ekaschalk/.spacemacs.d/blob/master/layers/display/local/pretty-fonts/pretty-fonts.el so that people can easily configure font-ligatures, what do you guys think?

@syl20bnr
Copy link
Owner

Indeed that would be nice 👍

@georgreen
Copy link

georgreen commented Dec 15, 2018

@mdedetrich doom emacs do have a rather complete implementation, including mathematics notation symbols. I would have taken up the port but I'm new to this stuff.

@mdedetrich
Copy link
Author

@georgreen The link you posted doesn't work, care to update it?

@georgreen
Copy link

georgreen commented Dec 17, 2018

@georgreen The link you posted doesn't work, care to update it? @mdedetrich

done

@ezmiller
Copy link

@georgreen I'm new to spacemacs/emacs (coming from vim). Is the link you posted above somethign that can be used to get FiraCode working with spacemacs?

@howdoicomputer
Copy link

howdoicomputer commented Jan 9, 2019

@ezmiller It'll probably be easier to follow the wiki instructions for FiraCode to enable ligatures. It's mostly copy and pasting a bunch of lisp into your user-config.

As for this thread, I am in love with https://github.com/ekaschalk/.spacemacs.d/tree/master/layers/display

@ekaschalk your stuff is awesome

@Aberrantfox
Copy link

Is there any progress on this? I've been trying to get ligatures working and it just doesn't seem to want to play ball... I'm not of the opinion that adding a bunch of elisp should be required t oget this kind of thing working, in vs code it's just a checkbox... Maybe I am missing a package that makes this very easy?

@carusog
Copy link

carusog commented Jul 3, 2019

I started to use Spacemacs very little weeks ago, and I found super difficult to set up font ligatures from Fira Code in it. Not knowing how to set up .spacemacs correctly, I ended up choosing emacs-mac that with a one line of settings, enables ligatures immediately.
I strongly believe that this should be a default feature in modern Spacemacs. I, like most of us, use it, in fact, just for the "out of the box" features, and is a great entry point to Emacs wonderful features.
Modern development use ligatures quite commonly lastly. It would be great to have this feature built-in to the distribution.

@ekaschalk
Copy link

Ligatures are coming to Emacs FYI. Harfbuzz is integrated on Emacs master and Eli says it is the final step to (true) ligature support.

https://old.reddit.com/r/emacs/comments/byddvm/emacsdevel_harfbuzz_is_now_available_on_master/

@hyiltiz
Copy link

hyiltiz commented Feb 29, 2020

My SPC h d s includes HarfBuz, but how do I use it/enable it? Using Fire Code or Hasklig didn't render => as expected after an emacs restart.

System Info 💻

  • OS: gnu/linux
  • Emacs: 28.0.50
  • Spacemacs: 0.300.0
  • Spacemacs branch: develop (rev. 3025040)
  • Graphic display: t
  • Distribution: spacemacs
  • Editing style: vim
  • Completion: ivy
  • Layers:
(ivy gtags ibuffer auto-completion better-defaults
     (shell :variables shell-default-height 30 shell-default-position 'bottom)
     git ess pandoc spell-checking syntax-checking version-control pdf semantic typography finance erc
     (ranger :variables ranger-show-preview t ranger-show-hidden t ranger-cleanup-eagerly t ranger-cleanup-on-disable t ranger-ignored-extensions
             '("mkv" "flv" "iso" "mp4"))
     shell-scripts emacs-lisp octave haskell go
     (latex :variables latex-enable-folding t)
     lua python scheme ruby javascript purescript vimscript
     (org :variables org-enable-reveal-js-support t)
     markdown html graphviz yaml csv)
  • System configuration features: XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS PDUMPER LCMS2 GMP

@Kazark
Copy link
Contributor

Kazark commented Oct 20, 2020

This PR was merged: #13921 I think that is at least partly relevant.

@hyiltiz
Copy link

hyiltiz commented Oct 21, 2020

To anyone interested, it seem unicode-fonts provides unicode-fonts-ligature-modes and unicode-fonts-enable-ligatures, which may be how the new support may be used.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

@github-actions github-actions bot added the stale marked as a stale issue/pr (usually by a bot) label Oct 21, 2021
@hyiltiz
Copy link

hyiltiz commented Oct 22, 2021

Is this really resolved? If so, we should just close it before the bot seals the issue.

@github-actions github-actions bot removed the stale marked as a stale issue/pr (usually by a bot) label Oct 22, 2021
@lebensterben
Copy link
Contributor

@hyiltiz
Last time I tried unicode-fonts layer does provide proper ligatures in GUI emacs.
So this problem per se is solved. Nevertheless it breaks lsp-ui.

@hyiltiz
Copy link

hyiltiz commented Nov 12, 2021

unicode-fonts breaks lsp-ui? Maybe we need to file an issue there and close this one?

@lebensterben
Copy link
Contributor

It's long known and reported.

@github-actions
Copy link

github-actions bot commented Dec 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

@github-actions github-actions bot added the stale marked as a stale issue/pr (usually by a bot) label Dec 9, 2022
@github-actions github-actions bot closed this as completed May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- Mailling list - Fonts New Layer stale marked as a stale issue/pr (usually by a bot)
Projects
None yet
Development

No branches or pull requests