Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find a way to map <SPC> m to , #283

Closed
syl20bnr opened this issue Dec 16, 2014 · 5 comments
Closed

Find a way to map <SPC> m to , #283

syl20bnr opened this issue Dec 16, 2014 · 5 comments
Labels
Enhancement ☺

Comments

@syl20bnr
Copy link
Owner

By default mapped to , but it will be driven by a dotspacemacs variable.
@bjarkevad
Copy link
Contributor

Got any idea of where one would go looking for a solution to this? :)

@trishume
Copy link
Contributor

One way would be to add a helper that binds both keys but that would require changing everywhere a space m binding is defined. There might be a fancier way that hooks into evil-leader's internal state though.

@bjarkevad
Copy link
Contributor

It would be nicer if it was handled completely transparently, so that layers that specify SPC m bindings don't have to worry about this change, so I guess evil-leader needs looking into?

@trishume
Copy link
Contributor

Yah I would start by reading the source code to evil-leader. The solution will likely be adding "advice' to the evil leader binding methods that check for m bindings and also add comma bindings.

@danielwuz danielwuz mentioned this issue Dec 19, 2014
Closed
@danielwuz
Copy link
Contributor

had some code to solve this problem, as in https://github.com/syl20bnr/spacemacs/pull/300/files. Comments and suggestions are welcomed.

syl20bnr pushed a commit that referenced this issue Dec 19, 2014
@danielwuz @syl20bnr
Fixes #283 Find a way to map <SPC> m to ,
cea9af8 
Better version from danielwuz
taheris pushed a commit to taheris/spacemacs that referenced this issue Dec 19, 2014
Merge branch 'master' into personal
e3b5e84 
* master:
  Update achievements
  Fixes syl20bnr#283 Find a way to map `<SPC> m` to `,`
  Fixes syl20bnr#283 Find a way to map `<SPC> m` to `,`
  Refactoring of some javascript layer package initialisation
  Fixed tern-auto-complete to load correctly
  Improve support for git-gutter in terminal
  git-gutter-fringe is now loaded properly before calling git-gutter-mode
  Enable undo-tree mode at startup (no lazy-loading)
  Attempt to fix syl20bnr#298 error with undo-tree
  Hotfix for Emacs wiki down and key-chord issue
vijaykiran pushed a commit to vijaykiran/spacemacs that referenced this issue Mar 17, 2015
@syl20bnr @vijaykiran
Fixes syl20bnr#283 Find a way to map <SPC> m to ,
9753610
vijaykiran pushed a commit to vijaykiran/spacemacs that referenced this issue Mar 17, 2015
@danielwuz @vijaykiran
Fixes syl20bnr#283 Find a way to map <SPC> m to ,
c15b03d 
Better version from danielwuz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement ☺
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@trishume @syl20bnr @bjarkevad @danielwuz