Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the haskell layer, disable ghc-mod messes important keybindings #3777

Closed
PierreR opened this issue Nov 12, 2015 · 2 comments
Closed

In the haskell layer, disable ghc-mod messes important keybindings #3777

PierreR opened this issue Nov 12, 2015 · 2 comments
Labels

Comments

@PierreR
Copy link
Contributor

PierreR commented Nov 12, 2015

How to reproduce
  • disable ghc-mod with :
    (haskell :variables haskell-enable-ghc-mod-support nil)
  • use SPC-h-d-k with c-c c-i (for instance)

=> it is wrongly bound to haskell-mode-enable-process-minor-mode

As a result, if you fire a repl with ,sb, you will never get the appropriate binding for c-c c-i (or `c-c c-t). It will always respond with "C-h f haskell-mode‘ for instruction".

System Info
  • OS: gnu/linux
  • Emacs: 24.5.1
  • Spacemacs: 0.105.0
  • Spacemacs branch: develop (rev. 39c69de)
  • Distribution: spacemacs
  • Layers:
(asciidoc auto-completion emacs-lisp erc dash dockerfile emacs-lisp emoji extra-langs git markdown
          (haskell :variables haskell-enable-ghc-mod-support nil)
          org
          (shell :variables shell-default-term-shell "/bin/zsh" shell-default-height 30 shell-default-position 'bottom)
          salt syntax-checking spell-checking puppet python version-control yaml)
@d12frosted
Copy link
Contributor

When I think about it - it makes sense. We force ,sb to run REPL. While C-c C-l and friends are set by ghc-mod or interactive-mode (or whatever else). So probably the best solution will be to enable haskell-interactive-mode when ghc-mod is disabled.

@PierreR
Copy link
Contributor Author

PierreR commented Nov 12, 2015

I actually thought that c-c c-t and c-c c-i would be automatically rebound to haskell-process-do-type and haskell-process-do-info by spacemacs.

This was supposed to be fixed by #3345 but the associated commit only bind SPC-mht and SPC-mhi to c-c c-t/ c-c c-i (maybe under the assumption the interactive-mode would rebound these keys ?)

SPC-mht and SPC-mhishould be mapped (as before) to 'haskell-process-do-info and 'haskell-process-do-type' but only whenever an interactive-mode is at play.

d12frosted added a commit to d12frosted/spacemacs that referenced this issue Nov 20, 2015
When user disabled ghc-mod, haskell mode should fallback to interactive
mode, so type bindings (and some others) are working properly. It's also
useful for ghci-ng users, but doesn't affect ghci-ng-only bindings.

Fix syl20bnr#3777
TheBB pushed a commit that referenced this issue Nov 23, 2015
When user disabled ghc-mod, haskell mode should fallback to interactive
mode, so type bindings (and some others) are working properly. It's also
useful for ghci-ng users, but doesn't affect ghci-ng-only bindings.

Fix #3777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants