Missing SPC binding in several modes

[StreakyCobra]

With the new bind-key transition, it seems that several modes have lost their SPC key binding:

• rspec-mode compilation window Gitter – November 28, 2015 4:04 PM
• speedbar-mode Evil leader broken in speedbar mode #3980
• ranger-mode [ranger] Leader key broken #3926
• python-nose Keymap issues in Python Nose #3940
• And maybe even terminals M- bindings no longer works in an ansi-term buffer #3927

[justbur]

I'll explain more later but the leader key is in the global evil maps. It's possible for minor modes to override these. you can rebind or unbind the shadowing key.

[autosquid]

and in c++ compilation mode.

[justbur]

evil-leader used local state maps for its bindings. bind-map uses the regular global maps, hence the small number of differences. Using local maps for what are essentially global bindings is a hack I think. Evil rightfully allows minor modes to override the global state maps which is what is happening here.

My preference would be to explicitly rebind in these cases because i think it more closely matches the intended design of evil mode. I can also make an option for bind-map to use the local maps like evil-leader if that's what people want.

[justbur]

@StreakyCobra this should be closed I think, since it doesn't affect master

[PierreR]

This is not fixed for Puppetfile mode using the latest develop 7be6176

[justbur]

@PierreR I took a look at puppetfile mode and it's defined in a somewhat non-standard way. I don't think the correct hooks are being run for it. We'll probably need to do something like this for it

(add-hook 'puppetfile-mode-hook
          (lambda ()
            (dolist (map (list evil-normal-state-local-map
                               evil-visual-state-local-map
                               evil-motion-state-local-map))
              (define-key map (kbd dotspacemacs-leader-key) 'spacemacs-cmds))))

[justbur]

Actually, I have another idea that might work through bind-map let me update it.

[justbur]

I think the puppetfile issue will be fixed after updating to justbur/emacs-bind-map@e239bbd