Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eshell clear leaves a line at top #5419

Closed
joshcho opened this issue Mar 9, 2016 · 3 comments
Closed

eshell clear leaves a line at top #5419

joshcho opened this issue Mar 9, 2016 · 3 comments
Labels
- Bug tracker - Fixed in develop Shells in Emacs stale marked as a stale issue/pr (usually by a bot)

Comments

@joshcho
Copy link

joshcho commented Mar 9, 2016

Entering clear leaves a line on top of eshell.

Reproducible by:
fresh install
enable shell layer
:eshell
type clear RET

image

When you press RET,

image

On the other hand, C-L, the equivalent command, works as intended.

System: OS X 10.11.3
Emacs: 24.5.1
@emberian emberian mentioned this issue Oct 15, 2016
Closed
aijony added a commit to aijony/spacemacs that referenced this issue Mar 12, 2017
@aijony
Prevent double newline after clear.
324fbb8 
Make it so inputting the clear command will _not_ result in two new lines.

Fixes syl20bnr#5419
aijony added a commit to aijony/spacemacs that referenced this issue Mar 12, 2017
@aijony
Fix and update eshell's clear features
71b0aa1 
Modify the default behavior for eshell's clear functionality.

 - Make eshell `clear RET` _similar_ to `C-l`
   - `clear RET` is eshell/clear
   - `C-l` is eshell-clear-stroke
 - Prevent `C-l` clearing cycle
 - Prevent `clear RET` inserting a page of white-space
 - Prevent duplicate insert lines from `clear RET`
 - Make eshell-clear-keystroke that is dependent on eshell/clear
 - Load both after eshell is initialized to prevent them from being overwritten

This fixes syl20bnr#5424, fixes syl20bnr#5419
@aijony aijony mentioned this issue Mar 13, 2017
Closed
syl20bnr pushed a commit that referenced this issue Apr 13, 2017
@aijony @syl20bnr
Fix and update eshell's clear features
6acf332 
Modify the default behavior for eshell's clear functionality.

 - Make eshell `clear RET` _similar_ to `C-l`
   - `clear RET` is eshell/clear
   - `C-l` is eshell-clear-stroke
 - Prevent `C-l` clearing cycle
 - Prevent `clear RET` inserting a page of white-space
 - Prevent duplicate insert lines from `clear RET`
 - Make eshell-clear-keystroke that is dependent on eshell/clear
 - Load both after eshell is initialized to prevent them from being overwritten

This fixes #5424, fixes #5419

Modify eshell clear statements load position

Change the clear statements load position from after loading eshell to
after enabling eshell.
This produces the same result, but is cleaner.
Note, they _cannot_ be defined before eshell loads, otherwise they are overwritten.

Refactor eshell-clear-keystroke to spacemacs/eshell-clear-keystroke

- Reduce steps needed to access clear command with define key
- Rename function to match naming conventions
  - The function shouldn't be accessed from the shell prompt
    - So not eshell/clear-keystroke
  - The function isn't from eshell.el
    - So not eshell-clear-keystroke
      - However, eshell/clear should be since it is overwriting a command
@syl20bnr
Copy link
Owner

should be fixed in develop

ksonney pushed a commit to ksonney/spacemacs that referenced this issue Apr 25, 2017
@aijony
Fix and update eshell's clear features
375f8a5 
Modify the default behavior for eshell's clear functionality.

 - Make eshell `clear RET` _similar_ to `C-l`
   - `clear RET` is eshell/clear
   - `C-l` is eshell-clear-stroke
 - Prevent `C-l` clearing cycle
 - Prevent `clear RET` inserting a page of white-space
 - Prevent duplicate insert lines from `clear RET`
 - Make eshell-clear-keystroke that is dependent on eshell/clear
 - Load both after eshell is initialized to prevent them from being overwritten

This fixes syl20bnr#5424, fixes syl20bnr#5419

Modify eshell clear statements load position

Change the clear statements load position from after loading eshell to
after enabling eshell.
This produces the same result, but is cleaner.
Note, they _cannot_ be defined before eshell loads, otherwise they are overwritten.

Refactor eshell-clear-keystroke to spacemacs/eshell-clear-keystroke

- Reduce steps needed to access clear command with define key
- Rename function to match naming conventions
  - The function shouldn't be accessed from the shell prompt
    - So not eshell/clear-keystroke
  - The function isn't from eshell.el
    - So not eshell-clear-keystroke
      - However, eshell/clear should be since it is overwriting a command
ksonney pushed a commit to ksonney/spacemacs that referenced this issue Apr 26, 2017
@aijony @ksonney
Fix and update eshell's clear features
297945a 
Modify the default behavior for eshell's clear functionality.

 - Make eshell `clear RET` _similar_ to `C-l`
   - `clear RET` is eshell/clear
   - `C-l` is eshell-clear-stroke
 - Prevent `C-l` clearing cycle
 - Prevent `clear RET` inserting a page of white-space
 - Prevent duplicate insert lines from `clear RET`
 - Make eshell-clear-keystroke that is dependent on eshell/clear
 - Load both after eshell is initialized to prevent them from being overwritten

This fixes syl20bnr#5424, fixes syl20bnr#5419

Modify eshell clear statements load position

Change the clear statements load position from after loading eshell to
after enabling eshell.
This produces the same result, but is cleaner.
Note, they _cannot_ be defined before eshell loads, otherwise they are overwritten.

Refactor eshell-clear-keystroke to spacemacs/eshell-clear-keystroke

- Reduce steps needed to access clear command with define key
- Rename function to match naming conventions
  - The function shouldn't be accessed from the shell prompt
    - So not eshell/clear-keystroke
  - The function isn't from eshell.el
    - So not eshell-clear-keystroke
      - However, eshell/clear should be since it is overwriting a command
@dieggsy
Copy link

dieggsy commented Aug 29, 2017

@syl20bnr I'm using the solution in develop for this (but not spacemacs), and I've noticed something sorta odd - If the last output had color sequences in it (as in /usr/bin/git -c status.color=always status), the prompt is colored with one of the colors in that output (I say one and not "the last" cause I haven't found it to be all that consistent). This doesn't happen with eshell's default clear function, and I'm not really sure how to troubleshoot from here.

CodingSolo pushed a commit to CodingSolo/spacemacs that referenced this issue Oct 29, 2018
@aijony
Fix and update eshell's clear features
1eefe33 
Modify the default behavior for eshell's clear functionality.

 - Make eshell `clear RET` _similar_ to `C-l`
   - `clear RET` is eshell/clear
   - `C-l` is eshell-clear-stroke
 - Prevent `C-l` clearing cycle
 - Prevent `clear RET` inserting a page of white-space
 - Prevent duplicate insert lines from `clear RET`
 - Make eshell-clear-keystroke that is dependent on eshell/clear
 - Load both after eshell is initialized to prevent them from being overwritten

This fixes syl20bnr#5424, fixes syl20bnr#5419

Modify eshell clear statements load position

Change the clear statements load position from after loading eshell to
after enabling eshell.
This produces the same result, but is cleaner.
Note, they _cannot_ be defined before eshell loads, otherwise they are overwritten.

Refactor eshell-clear-keystroke to spacemacs/eshell-clear-keystroke

- Reduce steps needed to access clear command with define key
- Rename function to match naming conventions
  - The function shouldn't be accessed from the shell prompt
    - So not eshell/clear-keystroke
  - The function isn't from eshell.el
    - So not eshell-clear-keystroke
      - However, eshell/clear should be since it is overwriting a command
@robbyoconnor robbyoconnor mentioned this issue Apr 12, 2019
Closed
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

@github-actions github-actions bot added the stale marked as a stale issue/pr (usually by a bot) label Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
- Bug tracker - Fixed in develop Shells in Emacs stale marked as a stale issue/pr (usually by a bot)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Thank you for contributing to Spacemacs! robbyoconnor/spacemacs
5 participants
@syl20bnr @StreakyCobra @bmag @joshcho @dieggsy