Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alias org-set-tags to counsel-org-tag when using ivy and org #6918

Closed
darkfeline opened this issue Aug 26, 2016 · 4 comments
Closed

Alias org-set-tags to counsel-org-tag when using ivy and org #6918

darkfeline opened this issue Aug 26, 2016 · 4 comments
Labels
- Mailling list - Fixed in develop Ivy Org

Comments

@darkfeline
Copy link
Contributor

The default ivy completion and org-set-tags is fairly useless since it doesn't complete after the first tag. ivy/counsel has a function for this that should replace org-set-tags entirely if ivy layer is used.

For reference: abo-abo/swiper#177
@ghost
Copy link

ghost commented Aug 26, 2016

I double that.

darkfeline added a commit to darkfeline/spacemacs that referenced this issue Sep 2, 2016
@darkfeline
Replace org-set-tags when ivy layer is used
09edc17 
When ivy is used, the default org-set-tags will only complete for the
first tag, and any additional tags must be typed manually.  counsel
provides a replacement function to fix this.

See syl20bnr#6918
@darkfeline darkfeline mentioned this issue Sep 2, 2016
Closed
darkfeline added a commit to darkfeline/spacemacs that referenced this issue Sep 22, 2016
@darkfeline
Use counsel-org-tag when ivy layer is used
d8f5d58 
When ivy is used, the default org-set-tags will only complete for the
first tag, and any additional tags must be typed manually.  counsel
provides a replacement function to fix this.

Unfortunately, we can't just alias org-set-tags because it is used in
other places, so we must change C-c C-c using a hook.

See syl20bnr#6918
@gilbertw1 gilbertw1 mentioned this issue Oct 19, 2016
Closed
syl20bnr pushed a commit that referenced this issue Jan 8, 2018
@darkfeline @syl20bnr
Use counsel-org-tag when ivy layer is used
fcf33be 
When ivy is used, the default org-set-tags will only complete for the
first tag, and any additional tags must be typed manually.  counsel
provides a replacement function to fix this.

Unfortunately, we can't just alias org-set-tags because it is used in
other places, so we must change C-c C-c using a hook.

See #6918
@syl20bnr
Copy link
Owner

syl20bnr commented Jan 8, 2018

@darkfeline thank you for the PR, merged in develop branch.

pinetr2e pushed a commit to pinetr2e/spacemacs that referenced this issue Mar 7, 2018
@darkfeline @pinetr2e
Use counsel-org-tag when ivy layer is used
f838753 
When ivy is used, the default org-set-tags will only complete for the
first tag, and any additional tags must be typed manually.  counsel
provides a replacement function to fix this.

Unfortunately, we can't just alias org-set-tags because it is used in
other places, so we must change C-c C-c using a hook.

See syl20bnr#6918
buckarooch pushed a commit to profilech/.emacs.d that referenced this issue May 19, 2018
@darkfeline @buckarooch
Use counsel-org-tag when ivy layer is used
0a6e393 
When ivy is used, the default org-set-tags will only complete for the
first tag, and any additional tags must be typed manually.  counsel
provides a replacement function to fix this.

Unfortunately, we can't just alias org-set-tags because it is used in
other places, so we must change C-c C-c using a hook.

See syl20bnr#6918
CodingSolo pushed a commit to CodingSolo/spacemacs that referenced this issue Oct 29, 2018
@darkfeline
Use counsel-org-tag when ivy layer is used
020df10 
When ivy is used, the default org-set-tags will only complete for the
first tag, and any additional tags must be typed manually.  counsel
provides a replacement function to fix this.

Unfortunately, we can't just alias org-set-tags because it is used in
other places, so we must change C-c C-c using a hook.

See syl20bnr#6918
@codygman
Copy link

I think this can be closed FYI.

@duianto
Copy link
Contributor

duianto commented Jan 29, 2020

Any issue that's marked as Fixed in develop will be closed when the next version is released.
But we can close this now. Thanks for the suggestion.

@duianto duianto closed this as completed Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
- Mailling list - Fixed in develop Ivy Org
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@codygman @TheBB @darkfeline @syl20bnr @d12frosted @duianto