Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup isn't unattended #7067

Closed
codygman opened this issue Sep 8, 2016 · 9 comments
Closed

Setup isn't unattended #7067

codygman opened this issue Sep 8, 2016 · 9 comments
Labels
- Mailling list - stale marked as a stale issue/pr (usually by a bot)

Comments

@codygman
Copy link

codygman commented Sep 8, 2016

Setup requires user to confirm our is okay to kill buffers so you can't just run setup and go do something else.

@TheBB
Copy link
Contributor

TheBB commented Sep 8, 2016

Packages are free to do whatever when compiling, there's not much we can do to guarantee an automatic installation.

@codygman
Copy link
Author

codygman commented Sep 8, 2016

Couldn't we disable all confirmations for setup and then enable them after?

On Sep 8, 2016 9:41 AM, "Eivind Fonn" notifications@github.com wrote:

Packages are free to do whatever when compiling, there's not much we can
do to guarantee an automatic installation.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#7067 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AANyN2WzPVX2yDWU6lt38N8mvUsckxikks5qoB6CgaJpZM4J4DG3
.

@TheBB
Copy link
Contributor

TheBB commented Sep 8, 2016

We could advise y-or-n-p perhaps, but it sounds risky. It's like answering without knowing what the question is.

@TheBB
Copy link
Contributor

TheBB commented Sep 8, 2016

To paraphrase Simon Peyton Jones, what if a package asks

(when (y-or-n-p "Launch the missiles?")
  (launch-missiles))

and we have advised y-or-n-p to always return yes?

@cpaulik
Copy link
Contributor

cpaulik commented Sep 8, 2016

@TheBB you are fast. Commenting from the future 😄

screenshot from 2016-09-08 23-37-05

Anyway I agree with you. And just advising y-or-n-p would probably not be enough since some packages like e.g. pdf-tools will also ask for the sudo password if they need to install system packages.

@codygman
Copy link
Author

codygman commented Sep 9, 2016

I didn't know there were packages that needed sudo. I suppose there isn't a sane way to handle this. I wonder if advising yes-or-no-p in cases except the sudo one you mention is possible though.

@d12frosted
Copy link
Contributor

screenshot 2016-09-12 22 19 08

💃 I like the jokes!

@JAremko
Copy link
Collaborator

JAremko commented Sep 12, 2016

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

@github-actions github-actions bot added the stale marked as a stale issue/pr (usually by a bot) label Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- Mailling list - stale marked as a stale issue/pr (usually by a bot)
Projects
None yet
Development

No branches or pull requests

5 participants