-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EPIC] Usability changes for multiple cursors functionality #11130
Conversation
;; | ||
;;; License: GPLv3 | ||
|
||
(defun spacemacs//paste-transient-state-p () |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rename this function to spacemacs//evil-mc-paste-transient-state-p
. The current name is too broad.
Great initiative! Do you think we can achieve to lazy-load it ? I see that you prepared the ground for supporting several multiple cursor backends. I'm not sure this is really possible to support Magnar's multiple cursors or if it even makes sense to do it. We can work to bring all the goodies (essentially some handy key bindings) from Magnar's MC to our layer based on On my side I'll try to make |
I am not yet sure about removing backends and focusing only on It's going to take me a lot of time to finish this, so I will start integrating small changes directly and use this PR as an epic to track my progress. |
I wanna learn how to use this so bad |
@robbyoconnor You can use the current functionality by enabling evil-mc with:
Then you have all the keybindings under What I've done so far was to add 2 more keybindings, the rest is just moving code from one place to another. Hopefully I can put some time aside this weekend to add more stuff. |
f934a52
to
c902cc7
Compare
;; | ||
;;; License: GPLv3 | ||
|
||
(defun spacemacs//evil-mc-paste-transient-state-p () |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the double slash //
a typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is equivalent to --
which denotes a function is "private" and should not be used in other files, or relied upon to have a stable API, or still exist in the future.
39eba62
to
a128cef
Compare
bfb6ea5
to
cd2b7de
Compare
cd2b7de
to
f95f8ad
Compare
Argument of |
Hey, I would like to start playing around with this (and maybe even, why not, participate to the effort) but can't find your commits anywhere, they seem to be all gone since you deleted the branch adn replaced the commits with this placeholder. Where are they ? |
@sdwolfz Omg, I actually tried to look in develop if they were not there but somehow managed to not see them 😅 Wonder what went on in my head |
Closing this as I'm not actively working on it, and I won't be able to in the near future. |
Improvements made to multiple cursors support:
.spacemacs.template
evil-mc
is implemented).Planning next:
This is a WIP, many more goodies to come...
Changes already cherry-picked: