Replace pbcopy by osx-clipboard

[suonlight]

Issue: #10896 (comment)

Why:

• When using emacs >= 26, pbcopy has latency actions in terminal.

This change addresses the need by:

• Replace pbcopy by osx-clipboard

[andresgutgon]

Nice!

[aaronjensen]

Looks okay to me, though It's going to make me disable it because it's not properly handling the case of one daemon serving terminal and gui clients. To do so, something like #10896 (comment) should be done, which would actually allow me to remove that custom code from my dotfiles and would be great.

Oh, and I'd remove that check for the emacs major version unless osx-clipboard has compatibility issues with <26.

[sdwolfz]

@suonlight will you be willing to incorporate @aaronjensen's suggested code as well?

[suonlight]

@sdwolfz ok, let me update by @aaronjensen's suggested code

[suonlight]

@andresgutgon, @sdwolfz, @aaronjensen please help me review it again. I have tested it with one daemon serving TUI and GUI client. Can you help me with other emacs version < 26?

[aaronjensen]

@suonlight this looks good to me. The only thing I might suggest is making those lambdas proper functions, but it's probably not necessary.

Ready to be merged! (@syl20bnr @TheBB @d12frosted @bmag @JAremko)

[theckman]

@duianto I saw you cherry-picked some open PRs in to develop the other day. I've also applied this patch on top of develop and can confirm that this results in Spacemacs working correctly on my system in both TUI an GUI mode. Without this patch TUI definitely is non-operable, and I've some issues with GUI mode.

Any chance you could also cherry-pick this one? It's the final issue that has me maintaining my own develop branch so that I have a fully functioning editor.

[duianto]

Thank you for contributing to Spacemacs!
The PR has been cherry-picked into the develop branch, you can safely delete your branch.