`spacemacs-theme'; no overrides. #11383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not override customizable settings from `spacemacs-theme', since those should be set on a per user basis in the configuration file.
robbyoconnor
reviewed
Oct 3, 2018
| :init (setq spacemacs-theme-keyword-italic t | ||
| spacemacs-theme-comment-bg t | ||
| spacemacs-theme-org-height t))) | ||
| :defer t)) |
There was a problem hiding this comment.
You can override these at will...
There was a problem hiding this comment.
That's correct. However, I had trouble setting those variables.
When having them in spacemacs/user-init, they are not honored upon startup by the theme because they are set too late (at least that is what happened to me, maybe because I am starting an Emacs server during boot).
When having them in spacemacs/init they are overridden by the lines that this pull request removes.
See also nashamri/spacemacs-theme#122
|
Have there been any thoughts about accepting or rejecting this pull request? Thanks! |
|
Thank you for contributing to Spacemacs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not override customizable settings from `spacemacs-theme', since those should
be set on a per user basis in the configuration file.