Fix pasting with universal argument #11858
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The auto-indent advice around evil-paste-{before,after} calls the advised funcs
without removing the universal argument. This results in errors like:
ad-Advice-evil-paste-before: Wrong type argument: number-or-marker-p, (4)
and, ultimately, in the paste failing.
This checks for the universal argument *before* calling the advised funcs,
adjusting the args to remove the universal argument.
Fixes syl20bnr#4219
Fixes syl20bnr#8897
|
Does this make #11340 obsolete? |
|
The following PR is now on the It superseded this one with two additional features:
source: #11340 (comment) |
This was referenced Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auto-indent advice around evil-paste-{before,after} calls the advised funcs
without removing the universal argument. This results in errors like:
and, ultimately, in the paste failing.
This checks for the universal argument before calling the advised funcs,
adjusting the args to remove the universal argument.
Fixes #4219
Fixes #8897