-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add describe evil ex-command functionality #14634
Add describe evil ex-command functionality #14634
Conversation
b468415
to
75bfc02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slick
Haha! Yeah it is a funny one... |
Probably quite unnecessary to refer to the already closed request #5577 |
core/core-debug.el
Outdated
func)) | ||
(if (stringp func) | ||
(spacemacs/describe-ex-command func) | ||
(describe-function func))))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If helpful
layer is enabled, we can use (helpful-callable func)
instead of (describe-function func)
.
The output is much more readable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing out, I have added it. On the other hand, the helpful layer could make describe-function
an alias
for helpful-callable
(and document it is aliased by the helpful layer in the docstring). Although that would probably be useful only for this single function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making it an alias, also keeps the ivy-actions
available. Right now, with the helpful layer, I loose the ivy actions Info
and definition
(which I use all the time) when using SPC h d f
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the other hand, I already had a personal helpful layer, where I bound the helpful function under SPC h h f
(etc.) , which is an alternative solution. The command is not called describe-function
anymore, but helpful-callable
, so that made more sense to me...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would vote to change those bindings in the helpful layer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or provide a configuration variable like helpful-prefer-alias
For introspection purposes it can be nice to have this functionality. Also this function can be used to discover which ex-commands are available.
75bfc02
to
b6369f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Hmmm not a bad idea about the alias in helpful layer, we just need to make sure to add the new third parameter to the alias call otherwise this will break emacs 28 again. |
For introspection purposes it can be nice to have this functionality. Also this
function can be used to get an overview of which ex-commands are available.