Fix #15306. Reflect eaf layer keybinding logic to upstream changes. #15436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anges. - Replace outdated eaf API call with most recent ones - Tested with eaf-browser on my machine - Both (kbd "SPC") and (kbd ",") works fine in eaf-browser
|
Since I don't use EAF, need some confirmation from other users. |
|
@dalanicolai can you have a look at those changes and confirm that the layer is working as expected? |
|
@smile13241324 The PR indeed fixes the issue and makes the layer work as expected... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant eaf layer keybinding code is based on suggestion from upstream eaf repo wiki. However, eaf API evolves faster than its wiki pages. This PR fixes #15306 using the workaround in the discussion.