-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove temp files /tmp/fineDiff* for kill-emacs without quit ediff #16765
Remove temp files /tmp/fineDiff* for kill-emacs without quit ediff #16765
Conversation
For context, here is the upstream bug which adds the ediff function mentioned here. |
IMO that's a pretty trivial bug, and I don't think "upstream Emacs will make this change eventually" is a generally a good reason on its own to backport a similar patch to Spacemacs---it's not even related to Spacemacs functionality, only ediff itself. I would vote to just close this, but will wait for others to chime in. |
I found the /tmp/fineDiff* files after Spacemacs So I hope Spacemacs user won't be bothered by using the |
That doesn't really address my root concern: I don't think backporting random things to Spacemacs is worth the maintenance burden, especially when the impact is so low. (I can't imagine the existence of some files in Can explain why these files not getting cleaned up is actually causing you problems? |
When using Spacemacs on a never-rebooted linux server with shared |
Okay so that's pretty specific to your site and not exactly catastrophic. Why not just fix it in your config, or use site-start? |
This issue happened on using the Spacemacs |
3ac7821
to
c712025
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As much as I dislike fixing emacs bugs in Spacemacs we have done this for a lot of broken packages in the past. Given how long it will take until a new emacs version is broadly accepted I think it makes sense to shield our users from those issues.
We can do cleanup once we increase the min emacs Version again.
@sunlin7 can you check the conflicts on your branch? Once its ready please ping me and I will check and merge it. |
* core/core-versions.el: New macro spacemacs/block-before-emacs-min-version * layers/+spacemacs/spacemacs-defaults/funcs.el: New function spacemacs//ediff-delete-temp-files. * layers/+spacemacs/spacemacs-defaults/packages.el: Use spacemacs//ediff-delete-temp-files on the kill-emacs-hook
c712025
to
b8f5c00
Compare
@smile13241324 Sure, had resolved the conflicts. Please help review again. Thank you ! |
Fix a bug that the temp files
/tmp/fineDiff*
were left after Spacemacs ediff templates.Reproducing steps: Pressing
SPC f e D
and pressn
to locate first diff line, then pressSPC f q
to quick Spacemacs directly.Then the
/tmp/fineDiff*
files left.