-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Perspectives lazy loading #2845
Conversation
fbb25e5
to
1933564
Compare
👀 👍 👓 👀 |
|
||
(defun perspectives/init-perspective () | ||
(use-package perspective | ||
:defer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be :defer t
? In any case, using :commands
implies :defer t
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed the :defer is irrelevant
I'm currently working in having a way to easily add custom perspectives and even having a microstate for them so please don't merge this one yet |
Great, I'm already enjoying the old perspectives layer, but the loading could be wonky. Curious what are the benefits of microstate over a hydra? |
for the benefits I think @syl20bnr could elaborate more on that. I'm not really that familiar with hydra either |
I like microstates personally |
microstates and hydra are the same thing, hydra is more powerful but:
I may in the future use hydras as backend for some part of the microstates but we will always have our own macro. |
I would love for spacemacs microstates to achieve something like this: http://emacs.stackexchange.com/a/14293 |
Hydra does not use magit-popup AFAIK. |
That's cool, we should be able to do this in microstates. |
The twitter hydra is here: https://github.com/abo-abo/hydra/wiki/Twittering |
what could we do then? it may be unreadable but the |
They work exactly like a hydra, this is the same thing underneath (look for transient maps in Emacs doc). |
To be fair, I barely understand emacs lisp :P On Tuesday, September 1, 2015, Sylvain Benner notifications@github.com
-Rob |
I'm familiar with the api and way to create ones but I mean the internals...I just look and the macro and hide on the corner scared of the backquotes and :bindings
alist-here
"h" foo-bar-function
|
What do you want to achieve with the perspective micro-state ? Is it something like eyebrowse ? |
@syl20bnr yes, it is working already D: |
1933564
to
86eed61
Compare
see above ^ |
ok so what do you want to do that does not work ? |
Custom perspectives can be defined by the user, this are perspectives that are not from projectile but let's say a perspective that open Rcirc with 4 channels opened. I want all custom perspectives, created with the spacemacs/create-custom-persp macro to be added into a variable, then create a microstate with the custom-perspectives |
I see, I wonder why you need to differentiate perspecitves and custom perspectives, I don't know perpsective :-) |
Why not having both in the same micro-state ? |
oh...the perspectives micro-state is for changing between opened perspectives... while custom perspectives create user-defined ones. |
oh ok, you may consider renaming the micro-state to incorporate a verb then, maybe |
branch |
so |
everyone |
can |
now |
test |
it |
I |
swapped |
the bindings |
for |
avy-jump-line |
and |
perspective micro-state |
because |
scopes |
have |
MOO
|
lower case |
keys |
thanks @person808 , I was going to hit 300 :-D Thank you @CestDiego, tremendous work on this one, I hope we will be able to make it the official layout solution for Spacemacs 👍 💜 |
BTW I hope I did not forget any commit, the history was indeed pretty funky :-) |
😂 |
Oops, I did not think about email spamming... my bad, sorry for this... time to go to bed I guess! |
@syl20bnr this is okay -- Spamming is okay :) |
Thank you all for the work on this branch! :) @cmccloud @TheBB @syl20bnr @person808 and everyone that helped in the process. |
Now that I understand better lazy loading and elisp I figured I'd give
the perspectives layer another go. I try to replicate the microstate
from Eyebrowse, but still working on the custom-perspectives.
I would appreciate some feedback until this is merged