spacemacs-core: Fix issues with major-mode leader

[justbur]

mode-map and major-mode-map were not let bound and had global scope. Seems like a bad idea for variables named like this

[justbur]

Added another change related to one of the issues brought up in #3000. It makes sense to use the same hook that evil-leader-mode does in binding the major-mode-leader key, so that we don't get the inconsistency between the leader being bound without the major-mode leader key being bound, which seems to be a result of one hook successfully firing and the previously used hook for the major-mode leader key not firing (because of an error in setting up the major-mode).

[TheBB]

YES, that's a good solution. 💯

[TheBB]

Although I should like to have it in both hooks, so that it updates if one actually does change the major mode. AFAICT there's no problem if this code runs twice.

[justbur]

@TheBB It will as it is here. evil-leader has to worry about the major-mode changing too. I'm just following it

[TheBB]

Hm, you're right, it works.

[justbur]

The idea is that it's as if we just rewrote evil-leader and added the code to the minor-mode initialization. For spacemacs we essentially need a version of evil-leader that support multiple leader keys

[syl20bnr]

Having our own evil-leader implementation can be considered. Also it may be useful to support minor modes if it is possible.

Thank you 👍
I moved the functions to a new file core-keybindings.el.

@TheBB @justbur I just realized that the choice of spacemacs-core for the base layer is not very smart... we already have a core in spacemacs... Do you have some alternative proposition while we can change it ?

Cherry-picked into develop branch, you can safely delete your branch.

[TheBB]

Kernel? Essentials?

[TheBB]

[justbur]

I like base layer. Something to build on.
On Mon, Sep 14, 2015 at 1:14 AM Eivind Fonn notifications@github.com
wrote:

http://i.imgur.com/i7LP5V9.png

—
Reply to this email directly or view it on GitHub
#3002 (comment).

[syl20bnr]

spacemacs-base ? I would prefer namespacing it so people are free to define a base layer for their own use.

[justbur]

Oh yes, sorry. That's what I meant

On Tue, Sep 15, 2015 at 9:29 AM, Sylvain Benner notifications@github.com
wrote:

spacemacs-base ? I would prefer namespacing it so people are free to
define a base layer for their own use.

—
Reply to this email directly or view it on GitHub
#3002 (comment).

[robbyoconnor]

I renamed spacemacs-core to spacemacs-base in #3048