emoji layer company-emoji font support #3864
Conversation
Font support for company-emoji on Linux or on Mac OS X and using the Cocoa version of Emacs. See https://github.com/dunn/company-emoji/blob/master/README.md
| (progn | ||
| (setq company-emoji-insert-unicode nil) | ||
| ;; From https://github.com/dunn/company-emoji/README.md for Linux, or on Mac OS X and using the Cocoa version of Emacs | ||
| (defun --set-emoji-font (frame) |
There was a problem hiding this comment.
If it's only useful in gui, wouldn't adding a guard when display-graphic-p in the function avoid it setting unnecessarily?
There was a problem hiding this comment.
Wasn't there a more useful function than display-graphic-p? so that this also works when spawned in daemon mode? @travisbhartwell
|
@codefalling why did you close this? |
|
it is very common for pull requests to take awhile to be merged... |
|
@robbyoconnor This pr got a strange |
|
@codefalling it might have been a git checkout taking too long to return...we don't have tests for layers currently and your change wouldn't impact Travis CI |
|
Go to the build details and look at the output -- most of the time it's not anyone's fault -- Travis CI sometimes just gives up |
|
There is a happy accident that closing and reopening pr would force Travis CI to rebuild 😄 |
|
Yes, closing/re-opening a pull request triggers a Travis CI build. |
|
[codetriage] status of this? |
|
Thank you ! 👍 |
Font support for company-emoji on Linux or on Mac OS X and using the Cocoa version of Emacs.
See https://github.com/dunn/company-emoji/blob/master/README.md