Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go] Enable org-babel integration #4128

Closed
wants to merge 1 commit into from
Closed

[go] Enable org-babel integration #4128

wants to merge 1 commit into from

Conversation

swaroopch
Copy link
Contributor

@swaroopch
Copy link
Contributor Author

@bogdanteleaga Can you please review this PR as well? :)

@bogdanteleaga
Copy link
Contributor

Hmm, I'm still quite bad at using org mode and I've never used babel before. But there doesn't seem to be much here, if it works I don't see why we wouldn't include it.

@swaroopch
Copy link
Contributor Author

@bogdanteleaga Thanks. You can try it out by typing this in org mode and in normal mode, do ,, or ctrl-c ctrl-c:

#+begin_src go :imports "fmt"
  fmt.Println("Hello, 世界")
#+end_src

You should see this appear below those lines:

#+RESULTS:
: Hello, 世界

(defun go/init-ob-go ()
(use-package ob-go
:if (configuration-layer/layer-usedp 'org)
:ensure t))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this :ensure t ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@syl20bnr You're right, the :ensure t is not needed, removing it in the next push to the branch.

P.S. Sorry for the delayed response!

@swaroopch
Copy link
Contributor Author

@syl20bnr The :ensure t has been removed. Can you please review?

@@ -5,6 +5,9 @@
flycheck
go-mode
go-eldoc
(ob-go :location (recipe
:fetcher github
:repo "pope/ob-go"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ob-go is on MELPA now

https://melpa.org/#/ob-go

@swaroopch
Copy link
Contributor Author

I made this PR exactly one year ago, since there doesn't seem to be interest in this, I'm closing this PR, if anybody is up for it, please feel free to take it forward.

@swaroopch swaroopch closed this Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants