Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #5190 - core: Add :packages keyword for layers #5339

Closed
wants to merge 1 commit into from
Closed

Fixes #5190 - core: Add :packages keyword for layers #5339

wants to merge 1 commit into from

Conversation

justbur
Copy link
Contributor

@justbur justbur commented Mar 3, 2016

This implements my proposal in #5190.

To restrict layer to only use pkg1 and pkg2 use
(layer
:packages (pkg1 pkg2))

To load all packages in a layer except pkg1 use
(layer
:packages (not pkg1))

@syl20bnr syl20bnr changed the title core: Add :packages keyword for layers Fix #5301 - core: Add :packages keyword for layers Mar 5, 2016
@syl20bnr syl20bnr self-assigned this Mar 5, 2016
@syl20bnr syl20bnr changed the title Fix #5301 - core: Add :packages keyword for layers Fixes #5190 - core: Add :packages keyword for layers Mar 5, 2016
@justbur
core: Add :packages keyword for layers
92cf686 
This implements my proposal in #5190.

To restrict layer to only use pkg1 and pkg2 use
(layer
  :packages (pkg1 pkg2))

To load all packages in a layer except pkg1 use
(layer
  :packages (not pkg1))

In the layer object, this translates to the :user-packages slot
@justbur
Copy link
Contributor Author

justbur commented Mar 8, 2016

This is breaking the help facility for some reason

@justbur justbur closed this Mar 8, 2016
@syl20bnr
Copy link
Owner

syl20bnr commented Mar 8, 2016

Which help facility does it break ?
Is this PR fixable ?

@justbur
Copy link
Contributor Author

justbur commented Mar 8, 2016

I was getting nil packages in ivy-spacemacs-help. You can use it. I just
didn't want to spend the time digging into what was wrong.

On Tue, Mar 8, 2016 at 11:57 AM Sylvain Benner notifications@github.com
wrote:

Which help facility does it break ?
Is this PR fixable ?

—
Reply to this email directly or view it on GitHub
#5339 (comment).

@syl20bnr
Copy link
Owner

syl20bnr commented Mar 8, 2016

Ok no problem, I'll look at it, thank you.

@syl20bnr syl20bnr mentioned this pull request May 20, 2016
Closed
@punassuming
Copy link
Contributor

@syl20bnr , @justbur. I can confirm the presence of nil layers in the helm-spacemacs-help and ivy-spacemacs-help variants; however this is found in the current develop branch, and is not tied to this PR. I applied the changes in this PR to the current head and it seems to be working fine. I did find a bug in ivy-spacemacs-help, but nothing pertaining to the :packages property implementation.

punassuming added a commit to punassuming/spacemacs that referenced this pull request Jun 8, 2016
@punassuming
Reimplement syl20bnr#5339 by justbur to add :packages keyword.
a3bb0b3
@punassuming punassuming mentioned this pull request Jun 8, 2016
Closed
punassuming added a commit to punassuming/spacemacs that referenced this pull request Jun 12, 2016
@punassuming
Reimplement syl20bnr#5339 by justbur to add :packages keyword.
fdb086d
punassuming added a commit to punassuming/spacemacs that referenced this pull request Jun 12, 2016
@punassuming
Reimplement syl20bnr#5339 by justbur to add :packages keyword.
ac4121c
syl20bnr pushed a commit that referenced this pull request Jun 21, 2016
@punassuming @syl20bnr
Reimplement #5339 by justbur to add :packages keyword.
704732f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@syl20bnr syl20bnr

Labels
Enhancement ☺
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justbur @syl20bnr @punassuming @StreakyCobra