Fix problems with multi-account setup in mu4e #5458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, account guessing for mu4e with multiple accounts has several problems: - Detection of email in `To` fields is broken. - It misses cc field or from field (replying to oneself) - if we are replying and no guess can be made, it fails. This commit rewrites the guessing function in a more robust maner, so that all the points above are addressed, and if no guess can be made, it just prompts the user asking for an account.
|
I just became aware of mu4e's 0.9.16 contexts, which I am going to use right away! In light of #4836 We can probably throw away this PR then... sorry for the noise! |
|
Closing as suggested. Feel free to reopen at any time if you change your mind :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, account guessing for mu4e with multiple accounts has several problems:
Tofields is broken.CCfield orFromfield (replying to oneself)This commit rewrites the guessing function in a more robust maner, so that all the points above are addressed, and if no guess can be made, it just prompts the user asking for an account.