Python inferior buffer improvement #598
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Projectile takes time to load (around 0.2 seconds) and it is lazy loading friendly if we want to enable it globally. To be able to lazy load it, we encapsulate the binded calls in spacemacs/xxx functions which take care of firing the mode globally if required.
instead of at loading time which is useless :-)
Sometimes the spacemacs key bindings for ido-vertical did not work.
I had to explicitly enable projectile-enable-caching and explicitly start projectile-mode to initialize projectile-projects-cache
Also add ?r projectile-replace to commander
It is now part of the package
This is the command for helm-projectile
Diminish it to Ⓖ
guide-key does not play well with golden-ratio. also set delay to 1 seconds, can be configured in .spacemacs for shorter delay
| (add-hook 'inferior-python-mode-hook '(lambda () | ||
| (smartparens-mode) | ||
| (evil-search-highlight-persist -1) | ||
| (global-evil-search-highlight-persist -1))) |
There was a problem hiding this comment.
Why globally disable it ?
I submitted a PR to remove the :global t in evil-search-highlight-persist. I hope it will be merged soon.
There was a problem hiding this comment.
I disabled globally just because otherwise evil-search-highlight-persist still takes in effect.
If evil-search-highlight-persist is not enabled globally by default, then there's no need to disable it =), I took it out.
|
Check with the new version which should be available soon. It fixes some activation issues and remove the global property. |
|
Great ! 👍 Cherry-picked into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made two improvement for python inferior buffer:
comint-clear-bufferbuffer from http://emacsredux.com/blog/2015/01/18/clear-comint-buffers/, and bind it toC-lin python inferior buffer.C-rto search inferior buffer commands backward, and disableevil-search-highlight-persistin python inferior buffer. Highlighting matched history in a repl buffer is quite annoying.Both
C-landC-rare compliant with the keys in a shell terminal.Since both updates are quite small, I kept them in one PR, although they're separate commits in git history. Let me know if I need to make separate PR. Thanks.