Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Restore SPC f s in ipython notebook layer. #6289

Closed
wants to merge 1 commit into from

Conversation

cpaulik
Copy link
Contributor

@cpaulik cpaulik commented Jun 11, 2016

Fix #5671

"u" 'ein:worksheet-change-cell-type
"u" 'ein:worksheet-change-cell-type)

(evil-leader/set-key-for-mode 'ein:notebook-multilang-mode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be spacemacs/set-leader-keys-for-major-mode? (the same as the key-bindings above)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Because then the keybinding would be SPC m f s

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test it? The docstring for evil-leader/set-key-for-mode tells me that

evil-leader/set-key-for-mode is an alias for spacemacs/set-leader-keys-for-major-mode in core-keybindings.el.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, I did this in a hurry. It seems that there no longer is a function that can do what we need here. I don't have time right now to dive into the spacemacs keybinding logic to set this up so it works with all the editing modes.

@cpaulik cpaulik changed the title Restore SPC f s in ipython notebook layer. WIP: Restore SPC f s in ipython notebook layer. Jun 12, 2016
@cpaulik
Copy link
Contributor Author

cpaulik commented Jun 16, 2016

Now I understand. The way evil-leader/set-key-for-mode works was changed in ee6a486 . That's why I thought we could just use it as before. Anyway I don't know enough about keymaps to change spacemacs//init-leader-mode-map in a way that would allow the behaviour we want here. Closing for now.

@cpaulik cpaulik closed this Jun 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants