Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Complete] Add xwidget layer #6604

Closed
wants to merge 1 commit into from
Closed

[Complete] Add xwidget layer #6604

wants to merge 1 commit into from

Conversation

tuhdo
Copy link
Contributor

@tuhdo tuhdo commented Jul 16, 2016

Add xwdiget layer that configures xwidget-browser to behave more like a
normal browser. In the future, anything related to xwidget - aside from
the browser - should be put here. Hence the name "xwidget".
here

@tuhdo tuhdo mentioned this pull request Jul 16, 2016
@CestDiego
Copy link
Contributor

I would like to state that I love how fast this community moves! <3 I am on OSX so can't test right now but OMG this is so great

@CestDiego
Copy link
Contributor

I do believe though that for OSS sake, we should think in Shareability of configuration so many more people can use this and extend this, this way it could be less of an spacemacs-layer only type, to a MELPA package that everyone can install and we can decide to use it as a Spacemacs layer too, kinda like what Spaceline became

@JAremko
Copy link
Collaborator

JAremko commented Jul 16, 2016

Vimium - good surce of inspiration for the future work 😉

@tuhdo tuhdo force-pushed the develop branch 2 times, most recently from 2bab2cc to 6e93b66 Compare July 16, 2016 19:16
@tuhdo tuhdo changed the title Add xwidget layer [WIP] Add xwidget layer Jul 16, 2016
@tuhdo
Copy link
Contributor Author

tuhdo commented Jul 16, 2016

I will try shorter implementation soon, without involving macro.

@tuhdo tuhdo force-pushed the develop branch 2 times, most recently from f977077 to 032dfa8 Compare July 17, 2016 03:45
@tuhdo tuhdo changed the title [WIP] Add xwidget layer [Complete] Add xwidget layer Jul 17, 2016
@tuhdo
Copy link
Contributor Author

tuhdo commented Jul 17, 2016

It's done now. The commit can be reviewed and merged.

@tuhdo
Copy link
Contributor Author

tuhdo commented Jul 17, 2016

I do believe though that for OSS sake, we should think in Shareability of configuration so many more people can use this and extend this, this way it could be less of an spacemacs-layer only type, to a MELPA package that everyone can install and we can decide to use it as a Spacemacs layer too, kinda like what Spaceline became

Sure I would like it that way. But let it be mature in here first, then we can expand it into a full package. And I think, in the future these features will be added to core Emacs eventually.

@CestDiego
Copy link
Contributor

Sure I would like it that way. But let it be mature in here first, then we can expand it into a full package. And I think, in the future these features will be added to core Emacs eventually.

My point was that by getting exposure from all the people wanting to try it out it could drive even more collaboration, it's very valid if it matures inside our community as well, just wanted to put it out there that we should be thinking about making this shareable in the future and this to drive the design decisions (not tying it too much to spacemacs-only helper functions, etc).

If we don't take that in mind, we are expecting a major rewrite in the future, which we might have to do anyway. In any case I'm happy this is being even done <3 thanks @tuhdo . I'll try to help out when I get my hands on a linux computer again T_T or if I figure out how to do this in OSX when I get a personal laptop

@tuhdo
Copy link
Contributor Author

tuhdo commented Jul 17, 2016

Now I added support for properly copy text from Xwidget browser. Here is a comparison:

  • Before:

emacs_xwidget_copy_text_old

  • After:

emacs_xwidget_copy_text_html

@CestDiego this layer does not depend anything in Spacemacs, but Xwidget itself. Sure, I will make a package out of it soon, when it works decentl

@tuhdo tuhdo force-pushed the develop branch 3 times, most recently from 9b69d4d to df5d51c Compare July 17, 2016 15:41
@tuhdo
Copy link
Contributor Author

tuhdo commented Jul 17, 2016

As @CestDiego suggested, I think it's fine to make a separate package now. I will do it soon. In the meantime, feel free to try this layer.

@tuhdo
Copy link
Contributor Author

tuhdo commented Jul 18, 2016

Done. The package is here: https://github.com/tuhdo/xwidgete

@CestDiego
Copy link
Contributor

Thank you @tuhdo for all this effort! :D

@syl20bnr
Copy link
Owner

Seems there are some unresolved security issues with libgtkwebkit, I did not check it though. We should add a warning in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants