Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing prefices for js2-mode #6965

Closed
wants to merge 1 commit into from
Closed

Add missing prefices for js2-mode #6965

wants to merge 1 commit into from

Conversation

shanavas786
Copy link
Contributor

skewer-eval-last-expression and skewer-eval-print-last-expression are on SPC e.
Move them under SPC s and add skewer prefix

@TheBB
Copy link
Contributor

TheBB commented Aug 30, 2016

https://github.com/syl20bnr/spacemacs/blob/develop/doc/CONVENTIONS.org#evaluation

SPC m e e should be the key binding for evaling expressions.

@shanavas786 shanavas786 force-pushed the add-missing-prefices branch from 6b95a12 to 27905a0 Compare August 31, 2016 07:34
@shanavas786 shanavas786 changed the title Add missing prefix and remap skewer bindings Add missing prefces for js2-mode Aug 31, 2016
@shanavas786 shanavas786 force-pushed the add-missing-prefices branch from 27905a0 to b18ac33 Compare August 31, 2016 07:37
@shanavas786
Copy link
Contributor Author

Thanks, refactored.

@TheBB
Copy link
Contributor

TheBB commented Aug 31, 2016

Thanks!

@shanavas786 shanavas786 changed the title Add missing prefces for js2-mode Add missing prefices for js2-mode Sep 1, 2016
@TheBB
Copy link
Contributor

TheBB commented Oct 17, 2016

Thanks! Cherry-picked in develop. You can safely delete your branch.

@TheBB TheBB closed this Oct 17, 2016
@gilbertw1 gilbertw1 mentioned this pull request Oct 18, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shanavas786 @TheBB