-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python: really start REPL also in emacs 25.1 #7070
Conversation
Make `python-start-or-switch-repl` start a REPL when necessery also in Emacs 25.1. Previously in Emacs 25.1 it wouldn't do anything if the REPL wasn't started already.
I am on 25.1 It works. I can open a REPL and send code to it.
This appears when I open a |
I see the code in this commit doesn't touch this variable, so this warning might not be related. It didn't happen up to a when the REPL stopped working, though (maybe it stopped because emacs was upgraded? Idk). |
I got this in the Inferior Python buffer that opened up:
|
@lukeorland probably not related to this PR, but there's not enough info to know for sure. If the same happens with |
We need this PR!!! 😄 |
I have tested this PR and it's working fine. The warning is related to a bug in upstream emacs https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24401. My current workaround is to set python-shell-completion-native-enable to nil, but it's not a real solution. However, I haven't tested what the guy in the bug report says. |
Thanks! Cherry-picked in develop. You can safely delete your branch. |
Make
python-start-or-switch-repl
start a REPL when necessery also in Emacs 25.1. Fixes #6628.The new version is supposed to work in Emacs 24.4, 24.5 and 25.1. For any daily python users: please confirm that this change doesn't break
SPC m '
if you're on 24.4 or 24.5, or confirm that it makesSPC m '
work if you're on 25.1.Edit: this PR also fixes #2872