auto load local .eslintrc

[xcodebuild]

Load .eslintrc from project's root if existed.

[AgIt0]

It should also be configurable somehow IMO, because a lot of projects I work on/I've seen keep the .eslintrc in a subfolder assets for instance

[bleggett]

This works well, and is super-needed, but I think it belongs in the general Javascript layer where eslint lives.

Also, I don't really know why Flycheck cares where the config is? Eslint will autodetect configs based on the directory structure and combine rules from ancestor .eslintrc files, so ideally we should just be able to give eslint the path of the file being checked and let it handle config discovery.

It seems weird to disable the checker because Flycheck can't find the config but the checker itself can.

This might be a Flycheck issue.

EDIT: See Using Configuration Files section of the Eslint docs: http://eslint.org/docs/user-guide/configuring

ESLint will automatically look for them in the directory of the file to be linted, and in successive parent directories all the way up to the root directory of the filesystem.

@codefalling I'd be willing to assist with getting this resolved and into master, as my day job requires eslint :)

[robbyoconnor]

Move to the javascript layer.

[robbyoconnor]

Move to the javascript layer.

[bleggett]

Looked into this more, and

• Current versions of eslint automatically discover .eslintrc files by walking up the folder tree from the file being checked.
• Current versions of flycheck do not try to find eslint config files, they just run eslint --print-config . which will return an exit code of 0 if eslint finds a config somewhere in the tree using the method above.
• Because of the above, the variable flycheck-eslintrc has been deprecated in flycheck.

So really, we shouldn't ever need to explicitly tell eslint or flycheck where the .eslintrc is, as long as it is somewhere in a parent folder or the project root, which is where eslint expects to find them.

Comments from @lunaryorn in the flycheck gitter:

 In this version Flycheck doesn't try to find an eslint configuration on its own; it calls eslint --print-config for that purpose, i.e. let's eslint look for a configuration and just checks whether eslint was successful. Flycheck must verify upfront whether eslint finds a configuration because eslint errors if it doesn't find a configuration so Flycheck must not attempt to use eslint in the absence of an eslint configuration.

See also the release notes for the latest flycheck release that confim: https://github.com/flycheck/flycheck/releases/tag/30

I updated flycheck, removed some old, bad .eslintrc config files from my folder tree, verified that running eslint --print-config . reported no errors, and verified that we do not need the above fix. If you open any JS file and eslint can find a config somewhere in the current or folder or the ancestor folder tree, everything should just work, with or without projectile.

[TheBB]

Thank you for that @bleggett!

[robbyoconnor]

@TheBB -- I'm pretty strong that this belongs in the javascript layer...not here...if this PR were to be accepted.

[syl20bnr]

So this PR is not needed?

If so, please merge it and then correct it in a new commit.

[robbyoconnor]

Shouldn't this be on the javascript layer though @syl20bnr?

[xcodebuild]

As @bleggett said, this PR is not needed. Should we close this?

[robbyoconnor]

Since it's in the wrong layer...yeah.

[TheBB]

Closing then since not needed, no matter what layer it's in.