Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Twitter Bootstrap support to org #7183

Closed
wants to merge 1 commit into from

Conversation

kalhauge
Copy link
Contributor

As a response to #6878, I added ox-twbs. I'm new to spacemacs, but it seams to work.

This pull request adds the ability to export to twitter bootstrap format, it's pretty much copy paste from the rest of the code. (ox-twbs)[https://github.com/marsmining/ox-twbs/] is licensed under GPLv3.

Copy link
Contributor

@robbyoconnor robbyoconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, however packages need to be in alphabetical order.

@@ -14,6 +14,9 @@
(defvar org-enable-github-support nil
"If non-nil Github related packages are configured.")

(defvar org-enable-bootstrap-support nil
"If non-nil Twitter Bootstrap related packages are configured.")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this above org-enable-github-support

@@ -525,6 +527,9 @@ Headline^^ Visit entry^^ Filter^^ Da
(defun org/init-ox-gfm ()
(spacemacs|use-package-add-hook org :post-config (require 'ox-gfm)))

(defun org/init-ox-twbs ()
(spacemacs|use-package-add-hook org :post-config (require 'ox-twbs)))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this above org/init-ox-gfm to be in alphabetical order

@@ -32,6 +32,8 @@
;; use a for of ox-gfm to fix index generation
(ox-gfm :location (recipe :fetcher github :repo "syl20bnr/ox-gfm")
:toggle org-enable-github-support)
(ox-twbs :location (recipe :fetcher github :repo "marsmining/ox-twbs")
:toggle org-enable-bootstrap-support)
(ox-reveal :toggle org-enable-reveal-js-support)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, put this before the ox-gfm package declaration.

@robbyoconnor
Copy link
Contributor

Keep the functions/packages in alphabetical order*

@kalhauge
Copy link
Contributor Author

Fixed it :). alphabetical order is now enforced

@lukehinds
Copy link

Would love to see this merged, as I was about to hack this in manually, but would prefer to pull from master instead.

@TheBB
Copy link
Contributor

TheBB commented Oct 17, 2016

Thanks! Cherry-picked in develop. I removed the recipe since this package is on MELPA. You can safely delete your branch.

@TheBB TheBB closed this Oct 17, 2016
@kalhauge kalhauge deleted the org-twbs-develop branch October 17, 2016 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants