Update documentation for Go-Guru switch #7247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bogdanteleaga any feedback? Trying to get @edrex's work moved forward |
d12frosted
reviewed
Oct 14, 2016
| Go Oracle has been deprecated as of October 1, 2016, it's replacement is =go-guru=. | ||
|
|
||
| If you would like to use the =goguru= bindings in your work, you will need to | ||
| install it, and in your project you will need to set the scope with =SPC m f o=. |
There was a problem hiding this comment.
Keybindings should be surrounded with ~.
|
It's not critical, but it would be nice if you fix your history, so it doesn't have that merge commit. It doesn't block me from merging (because I will simply cherry-pick two commits), but at least in future try to avoid such commits 😸 |
change to prefix for guru commands from `mr` to `mf` to separate from rename commands. Better prefix? Fixes syl20bnr#6772.
jredville
force-pushed
the
jim/go-guru
branch
from
d445ba6 to
a41c3d3
Compare
|
Updated, and will avoid in the future |
|
Thanks! Squashed your two commits and cherry-picked in develop. You can safely delete your branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is based off of @edrex's work on switching the go layer to use go-guru (#6774). It updates the documentation to warn about Oracle's deprecation and a few usage notes on go-guru.