Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map {j,k} to {next,previous}-error-no-select in anaconda-mode-view-mode #7538

Closed
wants to merge 1 commit into from

Conversation

mineo
Copy link
Contributor

@mineo mineo commented Oct 24, 2016

This is similar to the mappings done for flycheck-error-list-mode-map
and works around the broken evilification in
anaconda-mode-view-mode (see #5737).

This is similar to the mappings done for flycheck-error-list-mode-map
and works around the broken evilification in
anaconda-mode-view-mode (see syl20bnr#5737).
@bmag
Copy link
Contributor

bmag commented Oct 24, 2016

IIRC anaconda's help buffer also uses anaconda-mode-view-mode, so this binds j and k also when the user views the documentation of some variable or function. Can you check if it's still the case, and if there's some way to bind j and k only when appropriate (e.g. viewing usages)?

@mineo
Copy link
Contributor Author

mineo commented Oct 26, 2016

Hm, looks like you're right. Unfortunately anaconda-mode itself maps {next,previous}-error-no-select in anaconda-mode-view-mode (https://github.com/proofit404/anaconda-mode/blob/master/anaconda-mode.el#L716-L721), but only on C-n/C-p, which is less annoying if you only use it for viewing documentation than j/k here. I'll close this for now because I don't have the time to look into finding a better solution atm.

@mineo mineo closed this Oct 26, 2016
nixmaniack added a commit to nixmaniack/spacemacs that referenced this pull request Nov 28, 2016
* layers/+lang/python/funcs.el (spacemacs/anaconda-view-forward-and-push):
  Added helper function to go forward and hit RET
* layers/+lang/python/packages.el (python/init-anaconda-mode):
   - use new evilification macro
   - use helper function to go ahead and push button when hitting `RET`
   - Add `C-j`, `C-k` for easy navigation in anaconda-view-mode when multiple
   references are displayed. Doesn't conflict with normal `hjkl` navigation in
   other views of `anaconda-view-mode`

Fix syl20bnr#7538
Fix syl20bnr#5737
TheBB pushed a commit that referenced this pull request May 24, 2017
* layers/+lang/python/funcs.el (spacemacs/anaconda-view-forward-and-push):
  Added helper function to go forward and hit RET
* layers/+lang/python/packages.el (python/init-anaconda-mode):
   - use new evilification macro
   - use helper function to go ahead and push button when hitting `RET`
   - Add `C-j`, `C-k` for easy navigation in anaconda-view-mode when multiple
   references are displayed. Doesn't conflict with normal `hjkl` navigation in
   other views of `anaconda-view-mode`

Fix #7538
Fix #5737
CodingSolo pushed a commit to CodingSolo/spacemacs that referenced this pull request Oct 29, 2018
* layers/+lang/python/funcs.el (spacemacs/anaconda-view-forward-and-push):
  Added helper function to go forward and hit RET
* layers/+lang/python/packages.el (python/init-anaconda-mode):
   - use new evilification macro
   - use helper function to go ahead and push button when hitting `RET`
   - Add `C-j`, `C-k` for easy navigation in anaconda-view-mode when multiple
   references are displayed. Doesn't conflict with normal `hjkl` navigation in
   other views of `anaconda-view-mode`

Fix syl20bnr#7538
Fix syl20bnr#5737
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants