Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes python compile command #824

Closed
wants to merge 2 commits into from

Conversation

cpaulik
Copy link
Contributor

@cpaulik cpaulik commented Mar 14, 2015

  • now sets the compile command correctly if python buffers are switched and compile command was set already
  • moves point to end of comint buffer when switching to it, useful if a breakpoint is set

related to issue #805

- now sets the compile command correctly if python buffers are switched
- moves point to end of comint buffer, useful if a breakpoint is set
this enables autocompletion
This code still has the bug that point stays in the comint buffer
@cpaulik
Copy link
Contributor Author

cpaulik commented Mar 14, 2015

In the second commit I tried to activate inferior-python-mode for the created comint mode to enable autocompletion. This works but point does not return to the python buffer.

Maybe I am misunderstanding what (with-current-buffer) is supposed to do

@syl20bnr
Copy link
Owner

Sorry for the mistakes... made it late last night :-(
I have no focus issue while testing your PR, SPC m c c correctly stays in the python buffer whereas SPC m c C put the point in comint as expected.

👍 👍

Thank you !
Cherry-picked in develop.

@syl20bnr syl20bnr closed this Mar 15, 2015
@cpaulik
Copy link
Contributor Author

cpaulik commented Mar 15, 2015

No problem :-)

Strange, in my emacs the cursor switches to the comint buffer for both commands. With SPC m c c point is at the beginning of the buffer and with SPC m c C it is at the end.

@syl20bnr
Copy link
Owner

I does the expected behavior on my config, I wonder what could alter this . What's your version of Emacs ?

@cpaulik
Copy link
Contributor Author

cpaulik commented Mar 15, 2015

24.4.1 on Ubuntu 14.04.

We might be talking about slightly different things.
Until now I've always tested using a breakpoint in which case both commandos switch to the comint buffer.

Testing without a breakpoint, but an error in the file produces the correct behaviour.

@syl20bnr
Copy link
Owner

This is indeed what I have too. Is it something annoying we have to fix or
is it tolerable ?

-syl20bnr-

On Sun, Mar 15, 2015 at 5:40 PM, Christoph Paulik notifications@github.com
wrote:

24.4.1 on Ubuntu 14.04.

We might be talking about slightly different things.
Until now I've always tested using a breakpoint in which case both
commandos switch to the comint buffer.

Testing without a breakpoint, but an error in the file produces the
correct behaviour.


Reply to this email directly or view it on GitHub
#824 (comment).

@cpaulik
Copy link
Contributor Author

cpaulik commented Mar 15, 2015

It is tolerable for me since I will use SPC m c C if I have set a breakpoint. For me there is no point staying in the python src buffer in that case.

@cpaulik cpaulik deleted the fix-python-compile-mode branch March 16, 2015 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants