Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetReader #14

Closed
tri-adam opened this issue Jun 11, 2021 · 0 comments · Fixed by #17
Closed

Add GetReader #14

tri-adam opened this issue Jun 11, 2021 · 0 comments · Fixed by #17
Assignees
Labels
enhancement New feature or request

Comments

@tri-adam
Copy link
Member

(*Descriptor).GetReadSeeker currently returns an io.ReadSeeker, but I cannot find any usage of it that would not be satisfied by the simpler io.Reader interface. In the interest of simplifying the underlying implementation in a major version bump, I think we should consider deprecating GetReadSeeker and introducing:

func (d *Descriptor) GetReader(fimg *FileImage) io.Reader

This change can be introduced in a minor version, which will provide time before the planned removal of GetReadSeeker in a v2 API.

@tri-adam tri-adam added the enhancement New feature or request label Jun 11, 2021
@tri-adam tri-adam self-assigned this Jun 11, 2021
@tri-adam tri-adam mentioned this issue Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant