Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GetReadSeeker #15

Closed
tri-adam opened this issue Jun 11, 2021 · 0 comments · Fixed by #34
Closed

Remove GetReadSeeker #15

tri-adam opened this issue Jun 11, 2021 · 0 comments · Fixed by #34
Labels
v2 Affects v2 API

Comments

@tri-adam
Copy link
Member

tri-adam commented Jun 11, 2021 •
edited
Loading

(*Descriptor).GetReadSeeker currently returns an io.ReadSeeker, but current usage could be satisfied by the simpler io.Reader interface.

With the introduction of GetReader suggested by #14, I believe we should consider a breaking change to remove GetReadSeeker in the v2 API.
@tri-adam tri-adam added the v2 Affects v2 API label Jun 11, 2021
@tri-adam tri-adam mentioned this issue Jun 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v2 Affects v2 API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove GetReadSeeker
1 participant
@tri-adam