Bump github.com/satori/go.uuid Module #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest tagged version of the module contains the deficiency described in satori/go.uuid#73. Advancing to the commit where this issue was addressed.
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
=======================================
Coverage 64.79% 64.79%
=======================================
Files 11 11
Lines 1440 1440
=======================================
Hits 933 933
Misses 325 325
Partials 182 182 Continue to review full report at Codecov.
|
EmmEff
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #7 (comment), the latest tagged version of
github.com/satori/go.uuid(1.2.0) contains the deficiency described in satori/go.uuid#73.Ultimately, we need to move to a maintained UUID Go module as described in #7 (comment). But this will necessitate a major version bump, and we may want to consider other breaking changes while we're at that.
In the meantime, advancing
github.com/satori/go.uuidto the commit onmasterwhere this issue was addressed (satori/go.uuid@75cca53).