ensure element exists before access it (#356)

* ensure element exists before access it * use optional chaining
sylhare · Aug 3, 2022 · 1ba7d8d · 1ba7d8d
1 parent aa6f113
commit 1ba7d8d
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/assets/js/main.min.js b/assets/js/main.min.js
diff --git a/assets/js/partials/dark-mode.js b/assets/js/partials/dark-mode.js
@@ -15,7 +15,10 @@ const currentTheme = () => sessionStorage.getItem('theme')
 function setMode(theme) {
     document.documentElement.setAttribute('data-theme', theme)
     sessionStorage.setItem('theme', theme)
-    document.getElementById('theme-toggle').innerHTML = themeButton[theme]
+    const toggle = document.getElementById('theme-toggle')
+    if (toggle) {
+        toggle.innerHTML = themeButton[theme]
+    }
 }
 
 function themeToggle() {

diff --git a/assets/js/partials/navbar.js b/assets/js/partials/navbar.js
@@ -8,7 +8,7 @@ document.addEventListener("DOMContentLoaded", function (event) {
   const menu = document.querySelector('nav ul');
 
   ['click', 'touch'].forEach(function (e) {
-    pull.addEventListener(e, function () {
+    pull?.addEventListener(e, function () {
       menu.classList.toggle('hide')
     }, false);
   });
@@ -18,6 +18,9 @@ document.addEventListener("DOMContentLoaded", function (event) {
    */
   window.addEventListener('scroll', function () {
     const offset = -(window.scrollY || window.pageYOffset || document.body.scrollTop) / 3;
-    document.getElementById("main").style.backgroundPosition = '100% ' + (offset - 50) + 'px' + ', 0%, center top';
+    const main = document.getElementById('main');
+    if (main) {
+      main.style.backgroundPosition = '100% ' + (offset - 50) + 'px' + ', 0%, center top';
+    }
   });
 });