Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add author's avatar option #161

Merged
merged 6 commits into from
Jun 4, 2019
Merged

Add author's avatar option #161

merged 6 commits into from
Jun 4, 2019

Conversation

mhagnumdw
Copy link
Contributor

==> Please review what I modified !!! <==

Solves #154

If responsiveness and css are 100% correct, I don't know! 😬

Let me know if you want to change anything.

off-topic: If the PR is accepted, how about doing a squash for the master to avoid getting the tree dirty?

Preview
Add-author-s-avatar-option

@sylhare
Copy link
Owner

sylhare commented May 30, 2019

Thanks, I will review that 😉

@sylhare
Copy link
Owner

sylhare commented Jun 3, 2019

Hi @mhagnumdw , I was testing on my side and for some reason the avatar appears blank. Did you have this kind of trouble?

@mhagnumdw
Copy link
Contributor Author

Hi!

With avatars... all right here. Tested on: Chrome 73, FF 61 and 63, Vivaldi, Opera and Brave

But I noticed that FireFox is not displaying webp. I rarely use FireFox. Eg: header_feature_image

@sylhare
Copy link
Owner

sylhare commented Jun 4, 2019

Oh I will try again then ;)

@mhagnumdw
Copy link
Contributor Author

But I noticed that FireFox is not displaying webp. I rarely use FireFox. Eg: header_feature_image

😬 ohh, @sylhare I just updated my branch with the master now... and now that you converted webp into jpg, the problem in FireFox is gone

@sylhare
Copy link
Owner

sylhare commented Jun 4, 2019

Yup all working now. I like it 😄
I might do some changes to get some more articles with author and some without to see how it goes 😉

@sylhare sylhare merged commit ae533c8 into sylhare:master Jun 4, 2019
sylhare added a commit that referenced this pull request Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants