Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code fence highlight #258

Merged
merged 2 commits into from
Mar 29, 2021
Merged

Fix code fence highlight #258

merged 2 commits into from
Mar 29, 2021

Conversation

danisztls
Copy link
Contributor

@danisztls danisztls commented Mar 24, 2021 •
edited
Loading

  • Fix comments elements using wrong base16 color.
  • Create selector for selected text.

@danisztls danisztls changed the title Small fixes for code fence highlighting Fixes for code fence highlighting Mar 24, 2021
@danisztls danisztls changed the title Fixes for code fence highlighting Fix code fence highlight Mar 26, 2021
sylhare
sylhare reviewed Mar 26, 2021
View reviewed changes
Copy link
Owner

@sylhare sylhare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a code snippet that would render wrong for the highlighting? (So I can add it in one of the post example)
Sometime with Kramdown, some of the class are put differently based on the language.

@danisztls
Copy link
Contributor Author

danisztls commented Mar 26, 2021 •
edited
Loading

Was there a code snippet that would render wrong for the highlighting? (So I can add it in one of the post example)
Sometime with Kramdown, some of the class are put differently based on the language.

The snippets at "Markup: Syntax Highlighting" are enough.

Snippet with right comment color but wrong selection

Snippet with wrong comment color but right selection

@sylhare
Copy link
Owner

sylhare commented Mar 26, 2021

Ah indeed, the selection one was must needed 😅

sylhare
sylhare reviewed Mar 26, 2021
View reviewed changes
_sass/base/_highlight.scss Show resolved Hide resolved
_sass/base/_highlight.scss Show resolved Hide resolved
@sylhare sylhare merged commit af60e4b into sylhare:master Mar 29, 2021
@danisztls danisztls deleted the highlighting branch April 22, 2021 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylhare sylhare sylhare left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danisztls @sylhare