-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved version of adding utterances #289
Conversation
Everything works now. |
the label is optional |
all done and fully ready. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. 🚀
thanks |
a live demo of utterances is at my site. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I added some tiny comments ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since cusdis and disqus have only one line, ie cusdis_app_id
and disqus_shortname
, it is of no use to add them here. If you see Utterances, it has 3 lines plus 1 optional. So, Utterances has to work with the repo name to store the comments as issues, an issue term such as title which will make sure that the issue name is the blog title and theme for the theme for utterances. These three code lines are compulsory for .Utterances to work successfully.
You visit my personal blog, open the latest one and scroll down to comment in Utterances. Then, click here and go to the Issues section. Click the latest issue and you will see that the issue is stored on a specific repo, with a specific title and Utterances has a specific theme at the blog. |
Those three are required for Utterances to load perfectly. |
DisclaimerThis video file here is a live demo of Utterances. And, Sylhare, don't get shocked, it was all done on my fork of Type-on-Strap on Gitpod. Demo:utterances.test.mp4all things are good, and if you really want to see the issue, click here |
ping @sylhare @danisztls |
please check the attachment 🆙 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to try it, before merging ;)
Ok, and remember to fill up the first three lines in Utterances' code. It is added in the Readme too |
I merged your PR good job, thanks @coder-lg !! 😄 🎉 |
Thanks!!! |
The last PR I made was messed up. So, I fixed those errors and even tested it on Gitpod and it works like a charm. I even updated the readme, added a section for comments in the config.yml file.
live demo at my site
To Dos here:
last task: