Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore UseEmbeddedColorProfiles for animated PNGs #202

Merged
merged 5 commits into from
Jun 15, 2023

Conversation

qbnu
Copy link
Contributor

@qbnu qbnu commented Jun 3, 2023

This change allows users to have UseEmbeddedColorProfiles=true in their JPEGView.ini file without losing APNG support. ICC profiles are not supported for animated PNGs. See here for why we can't just integrate LCMS.

@sylikc
Copy link
Owner

sylikc commented Jun 5, 2023

cool. Thanks for contributing another working feature! It's been awhile... and thanks for helping support some of the issues recently!

@sylikc
Copy link
Owner

sylikc commented Jun 5, 2023

question: so, before, aPNG was disabled when use embedded was true...

is it a true statement that UseEmbedded does not work when APNG code is being run? aka, APNG does not support embedded color profiles?

@qbnu
Copy link
Contributor Author

qbnu commented Jun 5, 2023

question: so, before, aPNG was disabled when use embedded was true...

is it a true statement that UseEmbedded does not work when APNG code is being run? aka, APNG does not support embedded color profiles?

Yeah. I could add ICCP support with LCMS just for APNGs, but I don't know if anyone would ever use it. Maybe I'll do it for fun eventually.

@sylikc
Copy link
Owner

sylikc commented Jun 5, 2023

Got it. I was just gonna document it. No need to implement.

I could use help on the dcraw->libRAW conversion for fun if you have free time ☺️

I'll merge this, and I'm looking into all the small things I promised for the next release...

sylikc added a commit that referenced this pull request Jun 15, 2023
@sylikc sylikc merged commit 28e0305 into sylikc:master Jun 15, 2023
@sylikc sylikc added enhancement New feature or request format support Related to add/remove/change of a specific format support. labels Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request format support Related to add/remove/change of a specific format support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants